Attachment 86904 Details for Bug 22511 – Bug 22511: Update void method to use status

[patch] Bug 22511: Update void method to use status

Bug-22511-Update-void-method-to-use-status.patch (text/plain), 1.39 KB, created by Martin Renvoize (ashimema) on 2019-03-22 12:04:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-03-22 12:04:05 UTC

Size: 1.39 KB

patch

obsolete

>From 2392cd314ff3de5f0d8f69a5235c980ef8e31253 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 15 Mar 2019 14:07:24 +0000
>Subject: [PATCH] Bug 22511: Update void method to use status
>
>We added a 'status' field to 'accountlines' in bug 22512 to allow for
>more fined grained control over 'types' and 'states'.
>
>This patch updates the void method to utilise this new field so we may
>keep the original credit type for later auditing should it be required.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Account/Line.pm | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm
>index f0c426e849..bef72c4b39 100644
>--- a/Koha/Account/Line.pm
>+++ b/Koha/Account/Line.pm
>@@ -71,7 +71,11 @@ sub checkout {
> 
> =head3 void
> 
>-$payment_accountline->void();
>+  $payment_accountline->void();
>+
>+Used to 'void' (or reverse) a payment/credit. It will role back any offsets
>+created by the application of this credit upon any debits and mark the credit
>+as 'void' by updating it's status to "VOID".
> 
> =cut
> 
>@@ -133,7 +137,7 @@ sub void {
> 
>             $self->set(
>                 {
>-                    accounttype       => 'VOID',
>+                    status            => 'VOID',
>                     amountoutstanding => 0,
>                     amount            => 0,
>                 }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22511: 86674 | 86675 | 86903 | 86904 | 86905 | 86915 | 86916 | 86917 | 87088 | 87089 | 87090 | 87091 | 87221 | 87222 | 87223 | 87224 | 87632 | 87633 | 87634 | 87635 | 87650 | 87651 | 87652 | 87653 | 87654 | 87704 | 87706 | 87796 | 87797 | 87798 | 87799 | 87800 | 87869 | 87870 | 87871 | 87872 | 87873 | 88707 | 88708 | 88709 | 88710 | 88711 | 88712 | 88713 | 88714 | 88715 | 88748