Attachment 86943 Details for Bug 22550 – Bug 22550: OPAC suggestion form doesn't require mandatory fields

[patch] Bug 22550: OPAC suggestion form doesn't require mandatory fields

Bug-22550-OPAC-suggestion-form-doesnt-require-mand.patch (text/plain), 1.62 KB, created by ByWater Sandboxes on 2019-03-23 09:39:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2019-03-23 09:39:05 UTC

Size: 1.62 KB

patch

obsolete

>From 691be2d242ef3a56e8f5d169a9d14a81f37336e0 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 20 Mar 2019 16:24:42 +0000
>Subject: [PATCH] Bug 22550: OPAC suggestion form doesn't require mandatory
> fields
>
>Test plan:
>1. OPAC->login->your purchase suggestions->New purchase suggestion
>2. Click button "Submit your suggestion" directly without filling in any field.
>   Empty suggestion record was added succeffully.
>3. Apply the patch.
>4. Click button "Submit your suggestion" directly without filling in any field.
>   The required fields should be labeled in red.
>   (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields')
>
>Signed-off-by: Bin Wen <bin.wen@inlibro.com>
>
>Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com>
>
>Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index 7cfdc8fffa..f560e642b2 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -341,7 +341,7 @@
>         [% END %]
>         [% IF ( op_add && mandatoryfields ) %]
>         {
>-            var FldsRequired = [[% mandatoryfields | html %]];
>+            var FldsRequired = [[% mandatoryfields | $raw %]];
>             for (var i = 0; i < FldsRequired.length; i++) {
>                 var rq_input = $('#' + FldsRequired[i]);
>                 if (rq_input.length != 1) continue;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22550: 86823 | 86926 | 86942 | 86943 | 86959