Attachment 86971 Details for Bug 20954 – Bug 20954: (QA Follow-up) Rename syspref-overrides to syspref_overrides to maintain existing convention

[patch] Bug 20954: (QA Follow-up) Rename syspref-overrides to syspref_overrides to maintain existing convention

Bug-20954-QA-Follow-up-Rename-syspref-overrides-to.patch (text/plain), 2.34 KB, created by Kyle M Hall (khall) on 2019-03-25 12:21:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-03-25 12:21:09 UTC

Size: 2.34 KB

patch

obsolete

>From 901f3dd10276ef1da306514e77c537cfc78db462 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 25 Mar 2019 08:20:51 -0400
>Subject: [PATCH] Bug 20954: (QA Follow-up) Rename syspref-overrides to
> syspref_overrides to maintain existing convention
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/SIP/Sip/MsgType.pm | 8 ++++----
> etc/SIPconfig.xml     | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
>index a1021d727a..bd9de60915 100644
>--- a/C4/SIP/Sip/MsgType.pm
>+++ b/C4/SIP/Sip/MsgType.pm
>@@ -336,12 +336,12 @@ sub handle {
>     foreach my $key ( %ENV ) {
>         delete $ENV{$key} if index($key, 'OVERRIDE_SYSPREF_') > 0;
>     }
>-    foreach my $key ( keys %{ $config->{'syspref-overrides'} } ) {
>-        $ENV{"OVERRIDE_SYSPREF_$key"} = $config->{'syspref-overrides'}->{$key};
>+    foreach my $key ( keys %{ $config->{'syspref_overrides'} } ) {
>+        $ENV{"OVERRIDE_SYSPREF_$key"} = $config->{'syspref_overrides'}->{$key};
>     }
>-    foreach my $key ( keys %{ $server->{account}->{'syspref-overrides'} } ) {
>+    foreach my $key ( keys %{ $server->{account}->{'syspref_overrides'} } ) {
>         $ENV{"OVERRIDE_SYSPREF_$key"} =
>-          $server->{account}->{'syspref-overrides'}->{$key};
>+          $server->{account}->{'syspref_overrides'}->{$key};
>     }
> 
>     #
>diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml
>index 0406b10d79..aea68132a2 100644
>--- a/etc/SIPconfig.xml
>+++ b/etc/SIPconfig.xml
>@@ -60,9 +60,9 @@
>           <screen_msg_regex find="Greetings from Koha." replace="Welcome to your library!" />
>           <screen_msg_regex find="Invalid patron barcode." replace="Barcode not found, are you sure this is your library card?" />
>           <patron_attribute field="XY" code="CODE" />
>-          <syspref-overrides>
>+          <syspref_overrides>
>               <AllFinesNeedOverride>0</AllFinesNeedOverride>
>-          </syspref-overrides>
>+          </syspref_overrides>
>       </login>
>   </accounts>
> 
>@@ -108,8 +108,8 @@ in our case "ILS".
>      If the same system preference is overridden at the login level, the login
>      version will take precedence.
> -->
>-<syspref-overrides>
>+<syspref_overrides>
>       <AllFinesNeedOverride>0</AllFinesNeedOverride>
>-</syspref-overrides>
>+</syspref_overrides>
> 
> </acsconfig>
>-- 
>2.17.2 (Apple Git-113)

Actions: View | Diff | Splinter Review

Attachments on bug 20954: 76098 | 76103 | 86832 | 86971 | 92101 | 92102