Bugzilla – Attachment 86976 Details for
Bug 21646
Clean up Overdrive template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21646: Clean up Overdrive template
Bug-21646-Clean-up-Overdrive-template.patch (text/plain), 5.68 KB, created by
Owen Leonard
on 2019-03-25 14:03:21 UTC
(
hide
)
Description:
Bug 21646: Clean up Overdrive template
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-03-25 14:03:21 UTC
Size:
5.68 KB
patch
obsolete
>From 1c67937c63d00f36eab24e2ccff3b84bf0f0f455 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 24 Oct 2018 14:54:35 +0000 >Subject: [PATCH] Bug 21646: Clean up Overdrive template > >This patch modifies the OverDrive administration page to correct some >markup issues: > > - Switch to Bootstrap grid > - Add missing header search box > - Add missing DataTable configuration > - Remove unnecessary fieldset > >To test you do not need to have OverDrive credentials. Apply the patch >and go to System preferences -> Enhanced content -> OverDrive. In the >description of the "OverDriveAuthName" preference, follow the link to >manage "individual branch authnames." > > - Confirm that the page looks correct, including the header search > box, page title, and breadcrumbs > - Confirm that the page adjusts well to various browser window sizes. > - Confirm that the DataTable works correctly. >--- > .../prog/en/modules/admin/overdrive.tt | 97 +++++++++++++--------- > 1 file changed, 56 insertions(+), 41 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/overdrive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/overdrive.tt >index f5021ce..125121d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/overdrive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/overdrive.tt >@@ -4,62 +4,77 @@ > [% USE HtmlTags %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >-<title>Koha › Administration › Library OverDrive Info ›</title> >+<title>Koha › Administration › OverDrive library authnames</title> > [% INCLUDE 'doc-head-close.inc' %] > </head> > > <body id="admin_overdrive" class="admin"> >+ > [% INCLUDE 'header.inc' %] >+[% INCLUDE 'prefs-admin-search.inc' %] > >-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › <a href="/cgi-bin/koha/admin/overdrive.pl">Library OverDrive Info</a> › >+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › <a href="/cgi-bin/koha/admin/overdrive.pl">OverDrive library authnames</a> > </div> > >-<div id="doc3" class="yui-t2"> >+<div class="main container-fluid"> >+ <div class="row"> >+ <div class="col-sm-10 col-sm-push-2"> >+ <main> > >-<div id="bd"> >- <div id="yui-main"> >- <div class="yui-b"> >+ <h2>OverDrive library authnames</h2> > >-<form action="/cgi-bin/koha/admin/overdrive.pl" name="overdrive_form" method="post" class="validated"> >- <input type="hidden" name="op" value="update" /> >- <fieldset class="rows"> >- <legend> >- OverDrive >- </legend> >- <table id="od_info"> >- <thead> >- <th>Branch</th> >- <th>Authname</th> >- </thead> >- <tbody> >- [% FOREACH b IN branches %] >- <tr> >- <td> >- [% Branches.GetName( b.branchcode ) | html %] >- <input type="hidden" name="branchcode" value="[% b.branchcode | html %]" /> >- </td> >- <td> >- <input type="text" name="authname" value="[% b.authname | html %]" /> >- </td> >- </tr> >- [% END %] >- </tbody> >- </table> >- <input type="submit" value="Submit"> >-</form> >+ <form action="/cgi-bin/koha/admin/overdrive.pl" name="overdrive_form" method="post" class="validated"> >+ <input type="hidden" name="op" value="update" /> > >-</div> >-</div> >-<div class="yui-b"> >-[% INCLUDE 'admin-menu.inc' %] >-</div> >-</div> >+ <table id="od_info"> >+ <thead> >+ <tr> >+ <th>Library</th> >+ <th>Authname</th> >+ </tr> >+ </thead> >+ <tbody> >+ [% FOREACH b IN branches %] >+ <tr> >+ <td> >+ [% Branches.GetName( b.branchcode ) | html %] >+ <input type="hidden" name="branchcode" value="[% b.branchcode | html %]" /> >+ </td> >+ <td> >+ <input type="text" name="authname" value="[% b.authname | html %]" /> >+ </td> >+ </tr> >+ [% END %] >+ </tbody> >+ </table> >+ <div class="action"> >+ <input type="submit" value="Submit" /> >+ </div> >+ </form> >+ >+ </main> >+ </div> <!-- /.col-sm-10.col-sm-push-2 --> >+ >+ <div class="col-sm-2 col-sm-pull-10"> >+ <aside> >+ [% INCLUDE 'admin-menu.inc' %] >+ </aside> >+ </div> <!-- /.col-sm-2.col-sm-pull-10 --> >+ </div> <!-- /.row --> > > [% MACRO jsinclude BLOCK %] > [% Asset.js("js/admin-menu.js") | $raw %] > [% INCLUDE 'datatables.inc' %] >- [% INCLUDE 'columns_settings.inc' %] >- <script type="text/javascript"> >+ <script> >+ $(document).ready(function() { >+ $("#od_info").dataTable($.extend(true, {}, dataTablesDefaults, { >+ "aoColumnDefs": [ >+ { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false }, >+ ], >+ "sPaginationType": "four_button" >+ })); >+ }); > </script> > [% END %] >+ > [% INCLUDE 'intranet-bottom.inc' %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21646
:
81079
|
86976
|
86982
|
87175