Bugzilla – Attachment 86999 Details for
Bug 22539
Fines charged on back-dated checkin when item has been renewed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22539: Always recalculate fines when a return date is specified
Bug-22539-Always-recalculate-fines-when-a-return-d.patch (text/plain), 1.41 KB, created by
Martin Renvoize (ashimema)
on 2019-03-26 06:10:26 UTC
(
hide
)
Description:
Bug 22539: Always recalculate fines when a return date is specified
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-03-26 06:10:26 UTC
Size:
1.41 KB
patch
obsolete
>From 3521b99601d6739ea36ba2e79d807fdd49d44972 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 25 Mar 2019 13:29:13 -0400 >Subject: [PATCH] Bug 22539: Always recalculate fines when a return date is > specified > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Circulation.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index d15e4709aa..cfc1aff243 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1837,6 +1837,7 @@ sub AddReturn { > undef $branch; > } > $branch = C4::Context->userenv->{'branch'} unless $branch; # we trust userenv to be a safe fallback/default >+ my $return_date_specified = $return_date ? 1 : 0; > $return_date //= dt_from_string(); > my $messages; > my $patron; >@@ -1952,7 +1953,7 @@ sub AddReturn { > MarkIssueReturned( $borrowernumber, $item->itemnumber, $return_date, $patron->privacy ); > }; > unless ( $@ ) { >- if ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue ) { >+ if ( $return_date_specified || ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue ) ) { > _CalculateAndUpdateFine( { issue => $issue, item => $item_unblessed, borrower => $patron_unblessed, return_date => $return_date } ); > } > } else { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22539
:
86975
|
86985
|
86986
|
86998
|
86999
|
87341
|
87342
|
87343