Attachment 87005 Details for Bug 22076 – Bug 22076: Add missing whitespace on if statments

[patch] Bug 22076: Add missing whitespace on if statments

Bug-22076-Add-missing-whitespace-on-if-statments.patch (text/plain), 2.18 KB, created by Martin Renvoize (ashimema) on 2019-03-26 07:19:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-03-26 07:19:26 UTC

Size: 2.18 KB

patch

obsolete

>From 2303e9d062d30b6843466d5fdabf801671822056 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 9 Jan 2019 07:06:25 -0500
>Subject: [PATCH] Bug 22076: Add missing whitespace on if statments
>
>Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/SIP/ILS.pm | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm
>index e91588777c..aeaa0d2bec 100644
>--- a/C4/SIP/ILS.pm
>+++ b/C4/SIP/ILS.pm
>@@ -217,24 +217,24 @@ sub checkin {
>         return $circ;
>     }
> 
>-    if( !$circ->ok && $circ->alert_type && $circ->alert_type == 98 ) { # data corruption
>+    if ( !$circ->ok && $circ->alert_type && $circ->alert_type == 98 ) { # data corruption
>         $circ->screen_msg("Checkin failed: data problem");
>         syslog( "LOG_WARNING", "Problem with issue_id in issues and old_issues; check the about page" );
>-    } elsif( $data->{messages}->{withdrawn} && !$circ->ok ) {
>+    } elsif ( $data->{messages}->{withdrawn} && !$circ->ok ) {
>             $circ->screen_msg("Item withdrawn, return not allowed");
>             syslog("LOG_DEBUG", "C4::SIP::ILS::Checkin - item withdrawn");
>-    } elsif( $data->{messages}->{WasLost} && !$circ->ok ) {
>+    } elsif ( $data->{messages}->{WasLost} && !$circ->ok ) {
>             $circ->screen_msg("Item lost, return not allowed");
>             syslog("LOG_DEBUG", "C4::SIP::ILS::Checkin - item lost");
>-    } elsif( !$item->{patron} ) {
>-        if( $checked_in_ok ) { # Mark checkin ok although book not checked out
>+    } elsif ( !$item->{patron} ) {
>+        if ( $checked_in_ok ) { # Mark checkin ok although book not checked out
>             $circ->ok( 1 );
>             syslog("LOG_DEBUG", "C4::SIP::ILS::Checkin - using checked_in_ok");
>         } else {
>             $circ->screen_msg("Item not checked out");
>             syslog("LOG_DEBUG", "C4::SIP::ILS::Checkin - item not checked out");
>         }
>-    } elsif( $circ->ok ) {
>+    } elsif ( $circ->ok ) {
>         $circ->patron( $patron = C4::SIP::ILS::Patron->new( $item->{patron} ) );
>         delete $item->{patron};
>         delete $item->{due_date};
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22076: 83694 | 83709 | 83737 | 83738 | 83739 | 87000 | 87001 | 87002 | 87003 | 87004 | 87005