Bugzilla – Attachment 87025 Details for
Bug 20837
CanItemBeReserved should follow ReservesControlBranch and not CircControl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20837: (follow-up) Rename variables
Bug-20837-follow-up-Rename-variables.patch (text/plain), 1.69 KB, created by
Nick Clemens (kidclamp)
on 2019-03-26 14:54:26 UTC
(
hide
)
Description:
Bug 20837: (follow-up) Rename variables
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-03-26 14:54:26 UTC
Size:
1.69 KB
patch
obsolete
>From e061873d8d518d993dbdbe0de363e94da806f936 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 26 Mar 2019 14:54:12 +0000 >Subject: [PATCH] Bug 20837: (follow-up) Rename variables > >--- > C4/Reserves.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index e311c2b129..38c1bf0a73 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -442,10 +442,10 @@ sub CanItemBeReserved { > return { status => 'tooManyReserves', limit => $rule->rule_value} if $total_holds_count >= $rule->rule_value; > } > >- my $circ_control_branch = >+ my $reserves_control_branch = > GetReservesControlBranch( $item->unblessed(), $borrower ); > my $branchitemrule = >- C4::Circulation::GetBranchItemRule( $circ_control_branch, $item->itype ); # FIXME Should not be item->effective_itemtype? >+ C4::Circulation::GetBranchItemRule( $reserves_control_branch, $item->itype ); # FIXME Should not be item->effective_itemtype? > > if ( $branchitemrule->{holdallowed} == 0 ) { > return { status => 'notReservable' }; >@@ -1200,8 +1200,8 @@ sub IsAvailableForItemLevelRequest { > my $any_available = 0; > > foreach my $i (@items) { >- my $circ_control_branch = GetReservesControlBranch( $i->unblessed(), $borrower ); >- my $branchitemrule = C4::Circulation::GetBranchItemRule( $circ_control_branch, $i->itype ); >+ my $reserves_control_branch = GetReservesControlBranch( $i->unblessed(), $borrower ); >+ my $branchitemrule = C4::Circulation::GetBranchItemRule( $reserves_control_branch, $i->itype ); > > $any_available = 1 > unless $i->itemlost >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20837
:
75684
|
75685
|
87021
|
87022
|
87023
|
87024
|
87025
|
87409
|
87410
|
87673
|
87674
|
87675
|
88699
|
88700
|
88701