Bugzilla – Attachment 87040 Details for
Bug 14576
Allow automatic update of location on checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14576: Replaced calls using deprecated method GetItem with Koha::Items->find
Bug-14576-Replaced-calls-using-deprecated-method-G.patch (text/plain), 2.03 KB, created by
Hayley Pelham
on 2019-03-26 23:24:56 UTC
(
hide
)
Description:
Bug 14576: Replaced calls using deprecated method GetItem with Koha::Items->find
Filename:
MIME Type:
Creator:
Hayley Pelham
Created:
2019-03-26 23:24:56 UTC
Size:
2.03 KB
patch
obsolete
>From 5be02a885b5e8b221cf3dc6ad4296ef6fe09aedf Mon Sep 17 00:00:00 2001 >From: Hayley Mapley <hayleymapley@catalyst.net.nz> >Date: Wed, 27 Mar 2019 12:16:20 +1300 >Subject: [PATCH] Bug 14576: Replaced calls using deprecated method GetItem > with Koha::Items->find > >Test plan: >1) Apply all patches except this one >2) Checkout out an item to a patron >3) Check the item in - note that this will fail >4) Apply this patch, and repeat steps 1-3, noting instead that the the >check is instead successful >5) Verify also that reserves act as expected >5) Sign off > >Sponsored-by: Catalyst IT >--- > C4/Items.pm | 2 +- > C4/Reserves.pm | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index a06fdfabde..7d7a3e1c45 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -546,7 +546,7 @@ sub ModItemTransfer { > my ( $itemnumber, $frombranch, $tobranch ) = @_; > > my $dbh = C4::Context->dbh; >- my $item = GetItem( $itemnumber ); >+ my $item = Koha::Items->find( $itemnumber ); > > # Remove the 'shelving cart' location status if it is being used. > CartToShelf( $itemnumber ) if ( $item->{'location'} eq 'CART' && $item->{'permanent_location'} ne 'CART' ); >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 152ce7b851..d8bdc71073 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1028,7 +1028,7 @@ sub ModReserveStatus { > my $sth_set = $dbh->prepare($query); > $sth_set->execute( $newstatus, $itemnumber ); > >- my $item = GetItem($itemnumber); >+ my $item = Koha::Items->find($itemnumber); > if ( ( $item->{'location'} eq 'CART' && $item->{'permanent_location'} ne 'CART' ) && $newstatus ) { > CartToShelf( $itemnumber ); > } >@@ -1081,7 +1081,7 @@ sub ModReserveAffect { > if ( !$transferToDo && !$already_on_shelf ); > > _FixPriority( { biblionumber => $biblionumber } ); >- my $item = GetItem($itemnumber); >+ my $item = Koha::Items->find($itemnumber); > if ( ( $item->{'location'} eq 'CART' && $item->{'permanent_location'} ne 'CART' ) ) { > CartToShelf( $itemnumber ); > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14576
:
46454
|
46455
|
46456
|
48258
|
48259
|
50662
|
50663
|
52195
|
52196
|
52197
|
52204
|
52205
|
52206
|
52222
|
52223
|
52224
|
52365
|
53112
|
53113
|
53114
|
53115
|
54281
|
54644
|
54645
|
54646
|
54647
|
54648
|
54654
|
55587
|
60658
|
60659
|
60660
|
60661
|
60662
|
60663
|
60747
|
60748
|
60751
|
61940
|
61941
|
61942
|
61944
|
61945
|
61946
|
61947
|
61948
|
61949
|
61950
|
64656
|
64657
|
64658
|
67610
|
67611
|
68297
|
70795
|
70796
|
70797
|
72032
|
72033
|
72034
|
75661
|
75662
|
75663
|
79245
|
79246
|
79995
|
79996
|
83113
|
83114
|
83115
|
83696
|
83697
|
83698
|
85406
|
85850
|
85851
|
85852
|
85853
|
86812
|
86813
|
86814
|
86815
|
86816
|
87040
|
87061
|
87144
|
87145
|
87146
|
87147
|
87148
|
87149
|
87150
|
87151
|
87925
|
88451
|
88452
|
88453
|
88454
|
88455
|
88456
|
88457
|
88458
|
88459
|
88646
|
88647
|
88648
|
88649
|
88650
|
88651
|
88652
|
88653
|
88654