Bugzilla – Attachment 87072 Details for
Bug 22008
accountlines.manager_id is missing a foreign key constraint
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22008: (follow-up) Additional fix for bad test
Bug-22008-follow-up-Additional-fix-for-bad-test.patch (text/plain), 1.44 KB, created by
Martin Renvoize (ashimema)
on 2019-03-27 14:48:28 UTC
(
hide
)
Description:
Bug 22008: (follow-up) Additional fix for bad test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-03-27 14:48:28 UTC
Size:
1.44 KB
patch
obsolete
>From 5cd2e50861b9c2a04d0c413d23d20cbf27b99987 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 27 Mar 2019 14:47:27 +0000 >Subject: [PATCH] Bug 22008: (follow-up) Additional fix for bad test > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Circulation/Returns.t | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Circulation/Returns.t b/t/db_dependent/Circulation/Returns.t >index 88182cdccc..2f09606de5 100644 >--- a/t/db_dependent/Circulation/Returns.t >+++ b/t/db_dependent/Circulation/Returns.t >@@ -39,10 +39,19 @@ use MARC::Field; > > #Â Mock userenv, used by AddIssue > my $branch; >+my $manager_id; > my $context = Test::MockModule->new('C4::Context'); >-$context->mock( 'userenv', sub { >- return { branch => $branch, number => 1234, firstname => "Adam", surname => "Smaith" } >-}); >+$context->mock( >+ 'userenv', >+ sub { >+ return { >+ branch => $branch, >+ number => $manager_id, >+ firstname => "Adam", >+ surname => "Smaith" >+ }; >+ } >+); > > my $schema = Koha::Database->schema; > $schema->storage->txn_begin; >@@ -59,6 +68,9 @@ my $rule = Koha::IssuingRule->new( > ); > $rule->store(); > >+my $manager = $builder->build({source => 'Borrower'}); >+$manager_id = $manager->{borrowernumber}; >+ > subtest "InProcessingToShelvingCart tests" => sub { > > plan tests => 2; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22008
:
83278
|
83280
|
83460
|
83461
|
83462
|
85267
|
85268
|
85613
|
85614
|
85767
|
85768
|
86162
|
86163
|
86164
|
86659
|
86660
|
86661
|
86994
|
86995
|
87066
| 87072