Bugzilla – Attachment 87113 Details for
Bug 13895
Add routes for checkouts retrieval and renewal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13895: Adapt naming according to voted RFC
Bug-13895-Adapt-naming-according-to-voted-RFC.patch (text/plain), 3.61 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-03-27 17:27:52 UTC
(
hide
)
Description:
Bug 13895: Adapt naming according to voted RFC
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-03-27 17:27:52 UTC
Size:
3.61 KB
patch
obsolete
>From 7d5c439f965ff8940eff1f34f9a7e09166b53f42 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Wed, 13 Mar 2019 16:03:09 +0000 >Subject: [PATCH] Bug 13895: Adapt naming according to voted RFC > >--- > Koha/REST/V1/Checkout.pm | 4 ++-- > api/v1/swagger/definitions/checkout.json | 6 +++++- > api/v1/swagger/parameters.json | 4 ++-- > api/v1/swagger/parameters/checkout.json | 2 +- > api/v1/swagger/paths/checkouts.json | 4 ++-- > 5 files changed, 12 insertions(+), 8 deletions(-) > >diff --git a/Koha/REST/V1/Checkout.pm b/Koha/REST/V1/Checkout.pm >index 3dba36c316..e228216a96 100644 >--- a/Koha/REST/V1/Checkout.pm >+++ b/Koha/REST/V1/Checkout.pm >@@ -186,7 +186,7 @@ our $to_api_mapping = { > branchcode => 'library_id', > returndate => 'checkin_date', > lastreneweddate => 'last_renewed_date', >- issuedate => 'checked_out_date', >+ issuedate => 'checkout_date', > notedate => 'note_date', > }; > >@@ -202,7 +202,7 @@ our $to_model_mapping = { > library_id => 'branchcode', > checkin_date => 'returndate', > last_renewed_date => 'lastreneweddate', >- checked_out_date => 'issuedate', >+ checkout_date => 'issuedate', > note_date => 'notedate', > }; > >diff --git a/api/v1/swagger/definitions/checkout.json b/api/v1/swagger/definitions/checkout.json >index e540a55583..83cbe1a447 100644 >--- a/api/v1/swagger/definitions/checkout.json >+++ b/api/v1/swagger/definitions/checkout.json >@@ -39,11 +39,15 @@ > "type": "boolean", > "description": "Auto renewal" > }, >+ "auto_renew_error": { >+ "type": ["string", "null"], >+ "description": "Auto renewal error" >+ }, > "timestamp": { > "type": "string", > "description": "Last update time" > }, >- "checked_out_date": { >+ "checkout_date": { > "type": "string", > "format": "date-time", > "description": "Date the item was issued" >diff --git a/api/v1/swagger/parameters.json b/api/v1/swagger/parameters.json >index 0df77a78e8..11ce57cd9a 100644 >--- a/api/v1/swagger/parameters.json >+++ b/api/v1/swagger/parameters.json >@@ -17,8 +17,8 @@ > "vendoridPathParam": { > "$ref": "parameters/vendor.json#/vendoridPathParam" > }, >- "checkoutIdPathParam": { >- "$ref": "parameters/checkout.json#/checkoutIdPathParam" >+ "checkout_id_pp": { >+ "$ref": "parameters/checkout.json#/checkout_id_pp" > }, > "match": { > "name": "_match", >diff --git a/api/v1/swagger/parameters/checkout.json b/api/v1/swagger/parameters/checkout.json >index 8dfa3d2985..2bdb20ab84 100644 >--- a/api/v1/swagger/parameters/checkout.json >+++ b/api/v1/swagger/parameters/checkout.json >@@ -1,5 +1,5 @@ > { >- "checkoutIdPathParam": { >+ "checkout_id_pp": { > "name": "checkout_id", > "in": "path", > "description": "Internal checkout identifier", >diff --git a/api/v1/swagger/paths/checkouts.json b/api/v1/swagger/paths/checkouts.json >index 134aee55ad..1729826a4f 100644 >--- a/api/v1/swagger/paths/checkouts.json >+++ b/api/v1/swagger/paths/checkouts.json >@@ -39,7 +39,7 @@ > "operationId": "getCheckout", > "tags": ["patrons", "checkouts"], > "parameters": [{ >- "$ref": "../parameters.json#/checkoutIdPathParam" >+ "$ref": "../parameters.json#/checkout_id_pp" > }], > "produces": ["application/json"], > "responses": { >@@ -69,7 +69,7 @@ > "operationId": "renewCheckout", > "tags": ["patrons", "checkouts"], > "parameters": [{ >- "$ref": "../parameters.json#/checkoutIdPathParam" >+ "$ref": "../parameters.json#/checkout_id_pp" > }], > "produces": ["application/json"], > "responses": { >-- >2.21.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13895
:
37146
|
40104
|
40143
|
40588
|
41163
|
41548
|
45817
|
50021
|
51303
|
53816
|
53817
|
53878
|
53889
|
53890
|
53891
|
53901
|
53924
|
54196
|
54685
|
54951
|
56167
|
56506
|
58387
|
69123
|
84765
|
85458
|
85459
|
85460
|
85461
|
85462
|
85463
|
85464
|
85676
|
86120
|
86576
|
86579
|
86580
|
87105
|
87106
|
87107
|
87108
|
87109
|
87110
|
87111
|
87112
| 87113 |
87114
|
87115
|
87200