Bugzilla – Attachment 87115 Details for
Bug 13895
Add routes for checkouts retrieval and renewal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13895: (QA follow-up) Make the class plural
Bug-13895-QA-follow-up-Make-the-class-plural.patch (text/plain), 2.95 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-03-27 17:28:02 UTC
(
hide
)
Description:
Bug 13895: (QA follow-up) Make the class plural
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-03-27 17:28:02 UTC
Size:
2.95 KB
patch
obsolete
>From d7c82d7ba069cb090c494bdfd8b59e8e8433f4bf Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 27 Mar 2019 14:23:18 -0300 >Subject: [PATCH] Bug 13895: (QA follow-up) Make the class plural > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/REST/V1/{Checkout.pm => Checkouts.pm} | 10 +++++----- > api/v1/swagger/paths/checkouts.json | 6 +++--- > 2 files changed, 8 insertions(+), 8 deletions(-) > rename Koha/REST/V1/{Checkout.pm => Checkouts.pm} (92%) > >diff --git a/Koha/REST/V1/Checkout.pm b/Koha/REST/V1/Checkouts.pm >similarity index 92% >rename from Koha/REST/V1/Checkout.pm >rename to Koha/REST/V1/Checkouts.pm >index e228216a96..6c1c5e3985 100644 >--- a/Koha/REST/V1/Checkout.pm >+++ b/Koha/REST/V1/Checkouts.pm >@@ -1,4 +1,4 @@ >-package Koha::REST::V1::Checkout; >+package Koha::REST::V1::Checkouts; > > # This file is part of Koha. > # >@@ -135,8 +135,8 @@ attribute names. > sub _to_api { > my $checkout = shift; > >- foreach my $column ( keys %{ $Koha::REST::V1::Checkout::to_api_mapping } ) { >- my $mapped_column = $Koha::REST::V1::Checkout::to_api_mapping->{$column}; >+ foreach my $column ( keys %{ $Koha::REST::V1::Checkouts::to_api_mapping } ) { >+ my $mapped_column = $Koha::REST::V1::Checkouts::to_api_mapping->{$column}; > if ( exists $checkout->{ $column } && defined $mapped_column ) > { > $checkout->{ $mapped_column } = delete $checkout->{ $column }; >@@ -158,8 +158,8 @@ attribute names. > sub _to_model { > my $checkout = shift; > >- foreach my $attribute ( keys %{ $Koha::REST::V1::Checkout::to_model_mapping } ) { >- my $mapped_attribute = $Koha::REST::V1::Checkout::to_model_mapping->{$attribute}; >+ foreach my $attribute ( keys %{ $Koha::REST::V1::Checkouts::to_model_mapping } ) { >+ my $mapped_attribute = $Koha::REST::V1::Checkouts::to_model_mapping->{$attribute}; > if ( exists $checkout->{ $attribute } && defined $mapped_attribute ) > { > $checkout->{ $mapped_attribute } = delete $checkout->{ $attribute }; >diff --git a/api/v1/swagger/paths/checkouts.json b/api/v1/swagger/paths/checkouts.json >index 1729826a4f..6293401b8b 100644 >--- a/api/v1/swagger/paths/checkouts.json >+++ b/api/v1/swagger/paths/checkouts.json >@@ -1,7 +1,7 @@ > { > "/checkouts": { > "get": { >- "x-mojo-to": "Checkout#list", >+ "x-mojo-to": "Checkouts#list", > "operationId": "listCheckouts", > "tags": ["patrons", "checkouts"], > "parameters": [{ >@@ -35,7 +35,7 @@ > }, > "/checkouts/{checkout_id}": { > "get": { >- "x-mojo-to": "Checkout#get", >+ "x-mojo-to": "Checkouts#get", > "operationId": "getCheckout", > "tags": ["patrons", "checkouts"], > "parameters": [{ >@@ -65,7 +65,7 @@ > }, > "/checkouts/{checkout_id}/renewal": { > "post": { >- "x-mojo-to": "Checkout#renew", >+ "x-mojo-to": "Checkouts#renew", > "operationId": "renewCheckout", > "tags": ["patrons", "checkouts"], > "parameters": [{ >-- >2.21.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13895
:
37146
|
40104
|
40143
|
40588
|
41163
|
41548
|
45817
|
50021
|
51303
|
53816
|
53817
|
53878
|
53889
|
53890
|
53891
|
53901
|
53924
|
54196
|
54685
|
54951
|
56167
|
56506
|
58387
|
69123
|
84765
|
85458
|
85459
|
85460
|
85461
|
85462
|
85463
|
85464
|
85676
|
86120
|
86576
|
86579
|
86580
|
87105
|
87106
|
87107
|
87108
|
87109
|
87110
|
87111
|
87112
|
87113
|
87114
| 87115 |
87200