Attachment 87167 Details for Bug 21336 – Bug 21336: (QA follow-up) Add column_exists in db revision

[patch] Bug 21336: (QA follow-up) Add column_exists in db revision

Bug-21336-QA-follow-up-Add-columnexists-in-db-revi.patch (text/plain), 1.44 KB, created by Marcel de Rooy on 2019-03-29 08:34:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-03-29 08:34:16 UTC

Size: 1.44 KB

patch

obsolete

>From 73f6c9258089e43e12337df9d778d12951cdff63 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 29 Mar 2019 08:30:06 +0000
>Subject: [PATCH] Bug 21336: (QA follow-up) Add column_exists in db revision
>Content-Type: text/plain; charset=utf-8
>
>As requested by Josef on comment70.
>
>Test plan:
>Run db revision twice. No warnings.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> installer/data/mysql/atomicupdate/bug_21336a.perl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_21336a.perl b/installer/data/mysql/atomicupdate/bug_21336a.perl
>index 2ac9f76585..ad45908965 100644
>--- a/installer/data/mysql/atomicupdate/bug_21336a.perl
>+++ b/installer/data/mysql/atomicupdate/bug_21336a.perl
>@@ -1,7 +1,7 @@
> $DBversion = 'XXX';  # will be replaced by the RM
> if( CheckVersion( $DBversion ) ) {
>-    $dbh->do( "ALTER TABLE borrowers ADD COLUMN flgAnonymized tinyint DEFAULT 0" );
>-    $dbh->do( "ALTER TABLE deletedborrowers ADD COLUMN flgAnonymized tinyint DEFAULT 0" );
>+    $dbh->do( "ALTER TABLE borrowers ADD COLUMN flgAnonymized tinyint DEFAULT 0" ) if !column_exists('borrowers', 'flgAnonymized');
>+    $dbh->do( "ALTER TABLE deletedborrowers ADD COLUMN flgAnonymized tinyint DEFAULT 0" ) if !column_exists('deletedborrowers', 'flgAnonymized');
>     SetVersion( $DBversion );
>     print "Upgrade to $DBversion done (Bug 21336 - Add field flgAnonymized)\n";
> }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21336: 79165 | 79166 | 79167 | 79168 | 79169 | 79170 | 80201 | 80202 | 80203 | 80204 | 80205 | 80206 | 80207 | 80208 | 80213 | 80214 | 80386 | 80387 | 80403 | 81112 | 81113 | 81114 | 81115 | 81116 | 81117 | 81118 | 81119 | 81270 | 81474 | 81475 | 81476 | 81477 | 81478 | 81479 | 81480 | 81481 | 81482 | 81483 | 82051 | 82052 | 82053 | 82054 | 82055 | 82056 | 82057 | 82058 | 82059 | 83202 | 83203 | 83204 | 83205 | 83206 | 83207 | 83208 | 83209 | 83256 | 87158 | 87159 | 87160 | 87161 | 87162 | 87163 | 87164 | 87165 | 87166 | 87167 | 87168 | 87176 | 87177 | 87178 | 87179 | 87180 | 87181 | 87182 | 87183 | 87184 | 87185 | 87387 | 87388 | 87389 | 87390 | 87391 | 87392 | 87393 | 87394 | 87395 | 87396 | 87397 | 87400 | 87401 | 88198 | 88199 | 88217 | 88218