Attachment 87265 Details for Bug 20256 – Bug 20256: Refactor subs for rights to view patrons to make them generic for general use

[patch] Bug 20256: Refactor subs for rights to view patrons to make them generic for general use

Bug-20256-Refactor-subs-for-rights-to-view-patrons.patch (text/plain), 3.63 KB, created by Kyle M Hall (khall) on 2019-04-01 10:52:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-04-01 10:52:14 UTC

Size: 3.63 KB

patch

obsolete

>From f6dad02ba6e337f8b599548a11885b2d9b53191c Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 27 Mar 2019 13:06:54 -0400
>Subject: [PATCH] Bug 20256: Refactor subs for rights to view patrons to make
> them generic for general use
>
>---
> Koha/Patron.pm | 61 ++++++++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 57 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index eeaf0e4dc2..d89badc837 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -1125,10 +1125,34 @@ Return true if the patron (usually the logged in user) can see the patron's info
> 
> sub can_see_patrons_from {
>     my ( $self, $branchcode ) = @_;
>+
>+    return $self->can_see_things_from(
>+        {
>+            branchcode => $branchcode,
>+            permission => 'borrowers',
>+            subpermission => 'view_borrower_infos_from_any_libraries',
>+        }
>+    );
>+}
>+
>+=head3 can_see_things_from
>+
>+my $can_see = $thing->can_see_things_from( $branchcode );
>+
>+Return true if this "patron" ( usally the logged in user ) can perform some action on the given thing
>+
>+=cut
>+
>+sub can_see_things_from {
>+    my ( $self, $params ) = @_;
>+    my $branchcode    = $params->{branchcode};
>+    my $permission    = $params->{permission};
>+    my $subpermission = $params->{subpermission};
>+
>     my $can = 0;
>     if ( $self->branchcode eq $branchcode ) {
>         $can = 1;
>-    } elsif ( $self->has_permission( { borrowers => 'view_borrower_infos_from_any_libraries' } ) ) {
>+    } elsif ( $self->has_permission( { $permission => $subpermission } ) ) {
>         $can = 1;
>     } elsif ( my $library_groups = $self->library->library_groups ) {
>         while ( my $library_group = $library_groups->next ) {
>@@ -1154,7 +1178,36 @@ An empty array means no restriction, the patron can see patron's infos from any
> =cut
> 
> sub libraries_where_can_see_patrons {
>-    my ( $self ) = @_;
>+    my ($self) = @_;
>+
>+    return $self->libraries_where_can_see_things(
>+        {
>+            permission    => 'borrowers',
>+            subpermission => 'view_borrower_infos_from_any_libraries',
>+            group_feature => 'ft_hide_patron_info',
>+        }
>+    );
>+}
>+
>+=head3 libraries_where_can_see_things
>+
>+my $libraries = $thing-libraries_where_can_see_things;
>+
>+Returns a list of libraries where an aribitarary action is allowd to be taken by the logged in librarian
>+against an object based on some branchcode related to the object ( patron branchcode, item homebranch, etc ).
>+
>+We are supposing here that the object is related to the logged in librarian (use of C4::Context::only_my_library)
>+
>+An empty array means no restriction, the thing can see thing's infos from any libraries.
>+
>+=cut
>+
>+sub libraries_where_can_see_things {
>+    my ( $self, $params ) = @_;
>+    my $permission    = $params->{permission};
>+    my $subpermission = $params->{subpermission};
>+    my $group_feature = $params->{group_feature};
>+
>     my $userenv = C4::Context->userenv;
> 
>     return () unless $userenv; # For tests, but userenv should be defined in tests...
>@@ -1166,11 +1219,11 @@ sub libraries_where_can_see_patrons {
>     else {
>         unless (
>             $self->has_permission(
>-                { borrowers => 'view_borrower_infos_from_any_libraries' }
>+                { $permission => $subpermission }
>             )
>           )
>         {
>-            my $library_groups = $self->library->library_groups({ ft_hide_patron_info => 1 });
>+            my $library_groups = $self->library->library_groups({ $group_feature => 1 });
>             if ( $library_groups->count )
>             {
>                 while ( my $library_group = $library_groups->next ) {
>-- 
>2.20.1 (Apple Git-117)

Actions: View | Diff | Splinter Review

Attachments on bug 20256: 87226 | 87227 | 87228 | 87229 | 87230 | 87231 | 87232 | 87233 | 87262 | 87263 | 87264 | 87265 | 87266 | 87267 | 87268 | 87269 | 87270 | 88537 | 88539 | 88541 | 88542 | 88543 | 88544 | 88545 | 88546 | 88547 | 88632 | 88702 | 88703 | 88704 | 88705 | 88935 | 88936 | 96015 | 96016 | 96017 | 96018 | 96019 | 96020 | 96021 | 96022 | 96023 | 96024 | 96025 | 96026 | 96027 | 96028 | 96029 | 96030 | 96031 | 96032 | 96033 | 102622 | 102623 | 102624 | 102625 | 102626 | 102627 | 102628 | 102629 | 102630 | 102631 | 102632 | 102633 | 102634 | 102635 | 102636 | 102637 | 102638 | 102639 | 102640 | 102641 | 102642 | 102703 | 102704 | 102705 | 102706 | 102707 | 102708 | 102709 | 102710 | 102711 | 102712 | 102713 | 102714 | 102715 | 102716 | 102717 | 102718 | 102719 | 102720 | 102721 | 102722 | 102732 | 102733 | 102734 | 102735 | 102736 | 102737 | 102738 | 102739 | 102740 | 102741 | 102742 | 102743 | 102744 | 102745 | 102746 | 102747 | 102748 | 102749 | 102750 | 102751 | 107312 | 107313 | 107314 | 107315 | 107316 | 107317 | 107318 | 107319 | 107320 | 107321 | 107322 | 107323 | 107324 | 107325 | 107326 | 107327 | 107328 | 107329 | 107330 | 108851 | 108852 | 108853 | 108854 | 108855 | 108856 | 108857 | 108858 | 108859 | 108860 | 108861 | 108862 | 108863 | 108864 | 108865 | 108866 | 108867 | 108868 | 108869 | 108870 | 109939 | 110005 | 113706 | 113707 | 113708 | 113709 | 113710 | 113711 | 113712 | 113713 | 113714 | 113715 | 113716 | 113717 | 113718 | 113719 | 113720 | 113721 | 113722 | 113723 | 113724 | 113725 | 113726 | 113727 | 113728 | 116042 | 116043 | 116044 | 116045 | 116046 | 116047 | 116048 | 116049 | 116050 | 116051 | 116052 | 116053 | 116054 | 116055 | 116056 | 116057 | 116058 | 116059 | 116060 | 116061 | 116062 | 116063 | 116064 | 120055 | 120056 | 120057 | 120058 | 120059 | 120060 | 120061 | 120062 | 120063 | 120064 | 120065 | 120066 | 120067 | 120068 | 120069 | 120070 | 120071 | 120072 | 120073 | 120074 | 120075 | 120076 | 121771 | 121772 | 121773 | 121774 | 121775 | 121776 | 121777 | 121778 | 121779 | 121780 | 121781 | 121782 | 121783 | 121785 | 121786 | 121787 | 121788 | 121789 | 121790 | 121791 | 121792 | 124286 | 124287 | 124288 | 124289 | 124290 | 124291 | 124292 | 124293 | 124294 | 124295 | 124296 | 124297 | 124298 | 124299 | 124300 | 124301 | 124302 | 124303 | 124304 | 124305 | 124306 | 124307 | 124321 | 128734 | 128735 | 128736 | 128737 | 128738 | 128739 | 128740 | 128741 | 128742 | 128743 | 128744 | 128745 | 128746 | 128747 | 128748 | 128749 | 128750 | 128751 | 128752 | 128753 | 131676 | 131677 | 131678 | 131679 | 131680 | 131681 | 131682 | 131683 | 131684 | 131685 | 131686 | 131687 | 131688 | 131689 | 131690 | 131691 | 131692 | 131693 | 131694 | 131695 | 131696 | 131697 | 132483 | 132484 | 132486 | 132917 | 134375 | 134376 | 134377 | 139135 | 139136 | 139137 | 139138 | 139139 | 139140 | 139141 | 139142 | 139143 | 139144 | 139145 | 139146 | 139147 | 139148 | 139149 | 139150 | 139151 | 139152 | 139153 | 139154 | 139155 | 139156 | 139157 | 139158 | 139159 | 139160 | 139161 | 139162 | 139163 | 143527 | 143529 | 143530 | 143531 | 143532 | 143533 | 143534 | 143535 | 143536 | 143537 | 143538 | 143539 | 143540 | 143541 | 143542 | 143543 | 143544 | 143545 | 143546 | 143547 | 143548 | 143549 | 143550 | 143551 | 143552 | 143553 | 143554 | 143555 | 143556 | 145286 | 145287 | 145288 | 145289 | 145290 | 145291 | 145292 | 145293 | 145482 | 145483 | 145484 | 145485 | 145486 | 145487 | 145488 | 145489 | 145809 | 145810 | 145811 | 145812 | 145813 | 145814 | 145815 | 145816 | 145887 | 145888 | 145889 | 145890 | 145891 | 145892 | 145893 | 145894 | 145895 | 145896 | 145951 | 145952 | 145953 | 145954 | 145955