Attachment 87373 Details for Bug 22634 – Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql

[patch] Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql

Bug-22634-Standardize-table-creation-for-stockrota.patch (text/plain), 2.39 KB, created by Katrin Fischer on 2019-04-03 20:38:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-04-03 20:38:54 UTC

Size: 2.39 KB

patch

obsolete

>From 4399166c6d3e06c8384c2f44705487e156724850 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Wed, 3 Apr 2019 22:35:38 +0200
>Subject: [PATCH] Bug 22634: Standardize table creation for stockrotation*
> tables in kohastructure.sql
>
>The existing pattern is:
>DROP TABLE IF EXISTS ...
>CRATE TABLE
>
>Stockrotation was using:
>CREATE TABLE IF NOT EXISTS ...
>which would not recreate the table in a database it's already
>existing in possibly causing mismatches in table structure.
>
>To test:
>- Drop your database
>- Run through the web installer
>- Make sure there are no Database/SQL errors
>- Makse sure the 4 stockrotation tables have been created
>---
> installer/data/mysql/kohastructure.sql | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 012804a0ec..bdb37ff5e6 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -4270,7 +4270,8 @@ CREATE TABLE `circulation_rules` (
> -- Table structure for table `stockrotationrotas`
> --
> 
>-CREATE TABLE IF NOT EXISTS stockrotationrotas (
>+DROP TABLE IF EXISTS stockrotationrotas;
>+CREATE TABLE stockrotationrotas (
>     rota_id int(11) auto_increment,         -- Stockrotation rota ID
>     title varchar(100) NOT NULL,            -- Title for this rota
>     description text NOT NULL,              -- Description for this rota
>@@ -4283,7 +4284,8 @@ CREATE TABLE IF NOT EXISTS stockrotationrotas (
> -- Table structure for table `stockrotationstages`
> --
> 
>-CREATE TABLE IF NOT EXISTS stockrotationstages (
>+DROP TABLE IF EXISTS stockrotationstages;
>+CREATE TABLE stockrotationstages (
>     stage_id int(11) auto_increment,     -- Unique stage ID
>     position int(11) NOT NULL,           -- The position of this stage within its rota
>     rota_id int(11) NOT NULL,            -- The rota this stage belongs to
>@@ -4304,7 +4306,8 @@ CREATE TABLE IF NOT EXISTS stockrotationstages (
> -- Table structure for table `stockrotationitems`
> --
> 
>-CREATE TABLE IF NOT EXISTS stockrotationitems (
>+DROP TABLE IF EXISTS stockrotationitems;
>+CREATE TABLE stockrotationitems (
>     itemnumber_id int(11) NOT NULL,         -- Itemnumber to link to a stage & rota
>     stage_id int(11) NOT NULL,              -- stage ID to link the item to
>     indemand tinyint(1) NOT NULL default 0, -- Should this item be skipped for rotation?
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 22634: 87373 | 87482 | 87507