Attachment 87378 Details for Bug 21013 – Bug 21013: Missing itemtype for checkut makes patron summary print explode

[patch] Bug 21013: Missing itemtype for checkut makes patron summary print explode

Bug-21013-Missing-itemtype-for-checkut-makes-patro.patch (text/plain), 2.60 KB, created by Katrin Fischer on 2019-04-03 22:57:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-04-03 22:57:40 UTC

Size: 2.60 KB

patch

obsolete

>From 0208891dbc18b71073572d1359c33ec39c33b7ae Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 14 Mar 2019 13:15:01 +0000
>Subject: [PATCH] Bug 21013: Missing itemtype for checkut makes patron summary
> print explode
>
>This patch moves retrieval of the item type description from the script
>to the template using the ItemTypes template plugin.
>
>To test, apply the patch and locate an item which is checked out to
>someone. Modify the database record for that item to remove the item
>type (items.itype).
>
>View the print summary for the patron who has that item checked out. The
>page should display correctly. Checked-out items which have an item type
>should show that item type description correctly.
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt | 3 ++-
> members/summary-print.pl                                            | 3 ---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
>index 10ee5574e0..e5c6b8ea43 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
>@@ -2,6 +2,7 @@
> [% USE Branches %]
> [% USE KohaDates %]
> [% USE Price %]
>+[% USE ItemTypes %]
> [% SET footerjs = 1 %]
> 
> [% PROCESS 'accounts.inc' %]
>@@ -55,7 +56,7 @@
>                         </td>
>                         <td>[% issue.author | html %]</td>
>                         <td>[% issue.itemcallnumber | html %]</td>
>-                        <td>[% issue.itemtype_description | html %]</td>
>+                        <td>[% ItemTypes.GetDescription( issue.itype ) | html %]</td>
>                         <td>[% issue.date_due | $KohaDates  as_due_date => 1 %]</td>
>                         <td>[% issue.barcode | html %]</td>
>                         <td>[% issue.charge | $Price %]</td>
>diff --git a/members/summary-print.pl b/members/summary-print.pl
>index 76bb1d4213..38127c9061 100755
>--- a/members/summary-print.pl
>+++ b/members/summary-print.pl
>@@ -93,9 +93,6 @@ sub build_issue_data {
>         my ( $charge, $itemtype ) =
>           GetIssuingCharges( $checkout->{itemnumber}, $borrowernumber );
> 
>-        $itemtype = Koha::ItemTypes->find( $itemtype );
>-        $checkout->{itemtype_description} = $itemtype->description; #FIXME Should not it be translated_description
>-
>         $checkout->{charge} = $charge;
> 
>         $checkout->{overdue} = $c->is_overdue;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21013: 86600 | 87370 | 87378