Attachment 87404 Details for Bug 22444 – Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone

[patch] Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone

Bug-22444-currenciesmanage-permission-doesnt-provi.patch (text/plain), 2.34 KB, created by Katrin Fischer on 2019-04-04 09:41:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-04-04 09:41:36 UTC

Size: 2.34 KB

patch

obsolete

>From b869463d5eee3b35f2d5e47098dfc270763780cb Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 6 Mar 2019 19:02:50 +0000
>Subject: [PATCH] Bug 22444: currencies_manage permission doesn't provide link
> to manage currencies when selected alone
>
>This patch modifies the acquisitions sidebar menu so that it checks
>properly for the currencies_manage permission.
>
>This patch also removes the menu link directly to the administration
>home page. Since we're removing the check on the general
>"CAN_user_parameters" permission it doesn't make sense to assume the
>page is accessible.
>
>To test, apply the patch and modifiy a staff user so that they have no
>"parameters" permissions but do have "currencies_manage" permission.
>
>Go to the Acquisitions home page. There should be a link to currencies
>management in the sidebar menu.
>
>Perform the same test with a user who has "parameters" permissions but
>not "currencies_manage" permission. There should be no link to
>currencies in the acquisitions sidebar menu. The user should have access
>to the administrative home page.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc
>index 39da875c31..f5ef2e4579 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc
>@@ -10,10 +10,9 @@
>                 <li><a href="/cgi-bin/koha/acqui/edifactmsgs.pl">EDIFACT messages</a></li>
>             [% END %]
>         </ul>
>-        [% IF ( CAN_user_acquisition_period_manage || CAN_user_acquisition_budget_manage || CAN_user_parameters || CAN_user_acquisition_edi_manage ) %]
>+        [% IF ( CAN_user_acquisition_period_manage || CAN_user_acquisition_budget_manage || CAN_user_acquisition_currencies_manage || CAN_user_acquisition_edi_manage ) %]
>             <h5>Administration</h5>
>             <ul>
>-                <li><a href="/cgi-bin/koha/admin/admin-home.pl">Administration home</a></li>
>                 [% IF ( CAN_user_acquisition_period_manage ) %]
>                     <li><a href="/cgi-bin/koha/admin/aqbudgetperiods.pl">Budgets</a></li>
>                 [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22444: 86212 | 87404 | 87583