Attachment 87425 Details for Bug 22475 – Bug 22475: Shelving location doesn't appear on tags list view

[patch] Bug 22475: Shelving location doesn't appear on tags list view

Bug-22475-Shelving-location-doesnt-appear-on-tags-.patch (text/plain), 2.08 KB, created by Liz Rea on 2019-04-04 17:27:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2019-04-04 17:27:40 UTC

Size: 2.08 KB

patch

obsolete

>From 63bbec2e6ca29ccfa83244878d398fe9442bca96 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 7 Mar 2019 16:04:25 +0000
>Subject: [PATCH] Bug 22475: Shelving location doesn't appear on tags list view
>
>This patch corrects the tags list view so that shelving location appears
>correctly. Previously the template tried to display a variable which was
>empty.
>
>To test, apply the patch and locate an title which has both a tag
>applied to it and a shelving location defined for one or more items. Go
>to Tools -> Tags and click the tag to view titles with that tag. In the
>location column of the table the shelving location should appear along
>with library and call number.
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
>index dcad244d3f..6405c85755 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
>@@ -1,5 +1,6 @@
> [% USE raw %]
> [% USE Asset %]
>+[% USE AuthorisedValues %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Tools &rsaquo; Tags &rsaquo; [% IF ( do_it ) %]Review &rsaquo; [% ELSE %]Review tags[% END %]</title>
>@@ -47,7 +48,9 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
>             <td>[% IF ( title.items ) %]<ul style="font-size:80%">[% FOREACH item IN title.items %]
>                 <li>
>                     [% item.branchname | html %]
>-                    <span class="shelvingloc">[% item.location_description | html %]</span>
>+                    <span class="shelvingloc">
>+                        [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => item.location ) | html %]
>+                    </span>
>                     [% IF ( item.itemcallnumber ) %]
>                         ([% item.itemcallnumber | html %])
>                     [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22475: 86281 | 87425 | 87427