Attachment 87463 Details for Bug 22624 – Bug 22624: Show OPAC description for authorised values in OPAC

[patch] Bug 22624: Show OPAC description for authorised values in OPAC

Bug-22624-Show-OPAC-description-for-authorised-val.patch (text/plain), 6.83 KB, created by Mikaël Olangcay Brisebois on 2019-04-05 18:36:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mikaël Olangcay Brisebois

Created: 2019-04-05 18:36:18 UTC

Size: 6.83 KB

patch

obsolete

>From 74d878ef57d0538863c1dbf3488f3d72324ba581 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Mon, 1 Apr 2019 19:15:18 +0000
>Subject: [PATCH] Bug 22624: Show OPAC description for authorised values in
> OPAC
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Patch adds the IS_OPAC parameter to a few GetByCode calls in
>OPAC files.
>
>To test:
>- Add different OPAC and intranet descriptions to some authorised
> value categories:
> - TERM
> - DEPARTMENT
> - LOC
> - CCODE
>- Create a new course using the values and adding items to it
>- Check the course reserves overview and detail pages in OPAC
>- Verify Department, term, location, and collection show
> the OPAC description if existing
>- Create a subscription, make sure a default location is selected
>- Check the OPAC detail page, subscription tab for this subsription
> in the OPAC
>- Verify the location of the subscription displays correctly
>
>Signed-off-by: MikaÃ«l Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>
>---
> .../opac-tmpl/bootstrap/en/modules/opac-course-details.tt | 8 ++++----
> .../bootstrap/en/modules/opac-course-reserves.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++--
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt
>index 1e90cf88a9..c286ed6ca7 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt
>@@ -30,8 +30,8 @@
> <h2>Course reserves for [% course.course_name | html %]</h2>
> <div class="rows">
> <ol>
>- [% IF ( course.term ) %]<li>Term: [% AuthorisedValues.GetByCode( 'TERM', course.term ) | html %]</li>[% END %]
>- <li>Department: [% AuthorisedValues.GetByCode( 'DEPARTMENT', course.department ) | html %]</li>
>+ [% IF ( course.term ) %]<li>Term: [% AuthorisedValues.GetByCode( 'TERM', course.term, 1 ) | html %]</li>[% END %]
>+ <li>Department: [% AuthorisedValues.GetByCode( 'DEPARTMENT', course.department, 1 ) | html %]</li>
> [% IF ( course.course_number ) %]<li>Course number: [% course.course_number | html %]</li>[% END %]
> [% IF ( course.section ) %]<li>Section: [% course.section | html %]</li>[% END %]
> [% IF ( course.instructors ) %]
>@@ -71,8 +71,8 @@
> <td><a href="opac-detail.pl?biblionumber=[% cr.biblio.biblionumber | uri %]">[% cr.biblio.title | html %]</a></td>
> <td>[% cr.biblio.author | html %]</td>
> <td>[% ItemTypes.GetDescription( cr.item.itype ) | html %]</td>
>- <td>[% Branches.GetName( cr.item.holdingbranch ) | html %] [% AuthorisedValues.GetByCode( 'LOC', cr.item.location ) | html %]</td>
>- <td>[% AuthorisedValues.GetByCode( 'CCODE', cr.item.ccode ) | html %]</td>
>+ <td>[% Branches.GetName( cr.item.holdingbranch ) | html %] [% AuthorisedValues.GetByCode( 'LOC', cr.item.location, 1 ) | html %]</td>
>+ <td>[% AuthorisedValues.GetByCode( 'CCODE', cr.item.ccode, 1 ) | html %]</td>
> <td>[% cr.item.itemcallnumber | html %]</td>
> <td>[% cr.item.copynumber | html %]</td>
> <td>[% INCLUDE 'item-status.inc' item=cr.item issue=cr.issue %]</td>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt
>index 47c7fa1e22..1b97988e48 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt
>@@ -46,7 +46,7 @@
> <td>[% AuthorisedValues.GetByCode( 'DEPARTMENT', c.department, 1 ) | html %]</td>
> <td>[% c.course_number | html %]</td>
> <td>[% c.section | html %]</td>
>- <td>[% AuthorisedValues.GetByCode( 'TERM' c.term ) | html %]</td>
>+ <td>[% AuthorisedValues.GetByCode( 'TERM' c.term, 1 ) | html %]</td>
> <td>
> [% FOREACH i IN c.instructors %]
> <div class="instructor">[% i.surname | html %][% IF i.firstname %], [% i.firstname | html %][% END %]</div>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 3c5a40c8fa..7a4ca78f22 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -811,7 +811,7 @@
> This subscription is closed.
> [% END %]
> [% IF ( subscription.location ) %]
>- Location: [% AuthorisedValues.GetByCode( 'LOC', subscription.location ) | html %]
>+ Location: [% AuthorisedValues.GetByCode( 'LOC', subscription.location, 1 ) | html %]
> [% END %]
> [% IF ( subscription.callnumber ) %]
> Call number: [% subscription.callnumber | html %]
>@@ -1368,7 +1368,7 @@
> [% r.course.course_name | html %]
> 
> [% IF r.course.section %] [% r.course.section | html %] [% END %]
>- [% IF r.course.term %] [% AuthorisedValues.GetByCode( 'TERM', r.course.term ) | html %] [% END %]
>+ [% IF r.course.term %] [% AuthorisedValues.GetByCode( 'TERM', r.course.term, 1 ) | html %] [% END %]
> </a>
> 
> [% END %]
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 22624: 87332 | 87463 | 87505