Attachment 87466 Details for Bug 14358 – Bug 14358: Changing the module refreshes the page and resets library choice

[patch] Bug 14358: Changing the module refreshes the page and resets library choice

Bug-14358-Changing-the-module-refreshes-the-page-a.patch (text/plain), 3.82 KB, created by Katrin Fischer on 2019-04-06 09:50:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-04-06 09:50:36 UTC

Size: 3.82 KB

patch

obsolete

>From 9dfbdb5deb4b451ee54dedca5637bdf791bb3458 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 4 Apr 2019 14:05:21 +0000
>Subject: [PATCH] Bug 14358: Changing the module refreshes the page and resets
> library choice
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch makes an incremental change towards fixing Bug 14358: The
>"New notice" button is converted to a dropdown button which asks the
>user to select a module to start with.
>
>To test, apply the patch and go to Tools -> Notices. Test the "New
>notice" button and confirm that module selections are reflected in the
>notice add form you are shown.
>
>Signed-off-by: MikaÃ«l Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/modules/tools/letter.tt  | 26 +++++++++++++++++-----
> 1 file changed, 20 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>index d6f9e39f9a..086978561a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>@@ -58,12 +58,27 @@
>             </select>
>       </p>
>     [% END %]
>-      <div id="toolbar" class="btn-toolbar">
>-          <button type="submit" class="btn btn-default" id="newnotice"><i class="fa fa-plus"></i> New notice</button>
>-        <input type="hidden" id="op" name="op" />
>-      </div>
>     </form>
> 
>+        <div id="toolbar" class="btn-toolbar">
>+            <div class="btn-group">
>+                <button class="btn btn-default dropdown-toggle" data-toggle="dropdown"><i class="fa fa-plus"></i> New notice <span class="caret"></span></button>
>+                <ul class="dropdown-menu">
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=acquisition">Acquisition</a></li>
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=catalogue">Catalog</a></li>
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=circulation">Circulation</a></li>
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=claimacquisition">Claim acquisition</a></li>
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=claimissues">Claim serial issue</a></li>
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=reserves">Holds</a></li>
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=orderacquisition">Order acquisition</a></li>
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=members">Patrons</a></li>
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=serial">Serials (new issue)</a></li>
>+                    <li><a href="/cgi-bin/koha/tools/letter.pl?op=add_form&amp;module=suggestions">Suggestions</a></li>
>+
>+                </ul>
>+            </div>
>+        </div>
>+
> 		[% IF ( search ) %]
>         <p>You searched for <b>[% searchfield | html %]</b></p>
> 		[% END %]
>@@ -149,7 +164,6 @@
>         [% END %]
> [% END %]
> 
>-	
> [% IF add_form or copy_form %]
> <h1>[% IF ( modify ) %]Modify notice[% ELSE %]Add notice[% END %]</h1>
> 
>@@ -163,7 +177,7 @@
>                 <li><a id="saveandcontinue" href="#">Save and continue editing</a></li>
>             </ul>
>         </div>
>-        <a class="btn btn-default btn-sm cancel" href="/cgi-bin/koha/tools/letter.pl"><i class="fa fa-remove"></i> Cancel</a>
>+        <a class="btn btn-default cancel" href="/cgi-bin/koha/tools/letter.pl"><i class="fa fa-remove"></i> Cancel</a>
>     </div>
> 
>         <form id="add_notice" name="Aform" method="post" enctype="multipart/form-data" class="validate">
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 14358: 87417 | 87458 | 87466