Bugzilla – Attachment 87488 Details for
Bug 22656
Report charts broken after bug 22023
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22656: Fix charts in reports
Bug-22656-Fix-charts-in-reports.patch (text/plain), 1.75 KB, created by
Josef Moravec
on 2019-04-08 06:07:12 UTC
(
hide
)
Description:
Bug 22656: Fix charts in reports
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-04-08 06:07:12 UTC
Size:
1.75 KB
patch
obsolete
>From fec22c3d0c3a86435e07d3d8bdd68a8780e69e72 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Mon, 8 Apr 2019 06:03:42 +0000 >Subject: [PATCH] Bug 22656: Fix charts in reports > >This reverts a change on Create chart button in report toolbar made by >bug 22023 > >1) Confirm the bug > a) Create some SQL report > b) Run it and click on "Show chart settings" button > c) There is no modal or other way to actually draw the chart > >2) Apply the patch >3) Go through 1) again - the modal and chart should work > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >index 7e9b49ab20..df4f671d45 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >@@ -107,8 +107,7 @@ > <a class="btn btn-default toggle_sql" id="toggle_sql_vis" href="#" style="display:none;"><i class="fa fa-eye-slash"></i> Hide SQL code</a> > </div> > <div class="btn-group"> >- <a class="btn btn-default toggle_chart_settings" id="toggle_chart_settings_hid" href="#"><i class="fa fa-eye"></i> Show chart settings</a> >- <a class="btn btn-default toggle_chart_settings" id="toggle_chart_settings_vis" href="#" style="display:none;"><i class="fa fa-eye-slash"></i> Hide chart settings</a> >+ <a class="btn btn-default" href="#" data-toggle="modal" data-target="#chartModal"><i class="fa fa-bar-chart"></i> Create chart</a> > </div> > [% END %] > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22656
:
87488
|
87522
|
87559