Bugzilla – Attachment 87500 Details for
Bug 15326
Add CMS feature
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15326: (follow-up) Code review fixes
Bug-15326-follow-up-Code-review-fixes.patch (text/plain), 2.08 KB, created by
Martin Renvoize (ashimema)
on 2019-04-08 11:16:39 UTC
(
hide
)
Description:
Bug 15326: (follow-up) Code review fixes
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-04-08 11:16:39 UTC
Size:
2.08 KB
patch
obsolete
>From 77b32b207bad892b97837eaad0f0a0a8bad06b44 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 8 Apr 2019 12:14:31 +0100 >Subject: [PATCH] Bug 15326: (follow-up) Code review fixes > >Addresses the following issues: > >b) In opac-cmspages there is: >+ flagsrequired => { borrow => 1 }, >The borrow permission has been removed since. (blocker) > >c) Comment was removed unnecessarily, just needs to be moved into >its right spot below again: >-# If GoogleIndicTransliteration system preference is On Set >parameter to load Google's javascript in OPAC search screens > >d) One file uses qw( -utf-8) but another does not: >+use CGI; >+use CGI qw( -utf8 ); (blocker) > >Signed-off-by: Michal Denar <black23@gmail.com> > >Signed-off-by: Michal Denar <black23@gmail.com> >Rebased-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > opac/opac-cmspages.pl | 3 +-- > opac/opac-main.pl | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/opac/opac-cmspages.pl b/opac/opac-cmspages.pl >index 1cc68d0c4f..ac31dae08d 100755 >--- a/opac/opac-cmspages.pl >+++ b/opac/opac-cmspages.pl >@@ -18,7 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use CGI; >+use CGI qw( -utf8 ); > use C4::Auth; > use C4::Output; > use C4::Languages qw( getTranslatedLanguages accept_language ); >@@ -36,7 +36,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > type => "opac", > query => $input, > authnotrequired => ( C4::Context->preference( "OpacPublic" ) ? 1 : 0 ), >- flagsrequired => { borrow => 1 }, > } > ); > >diff --git a/opac/opac-main.pl b/opac/opac-main.pl >index c0c4c8c8b0..e94a6b41f2 100755 >--- a/opac/opac-main.pl >+++ b/opac/opac-main.pl >@@ -120,7 +120,7 @@ $template->param( > parent_list => $parent_list, > ); > >- >+# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens > > if (C4::Context->preference('GoogleIndicTransliteration')) { > $template->param('GoogleIndicTransliteration' => 1); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15326
:
45621
|
58272
|
58607
|
58608
|
58609
|
58787
|
63904
|
63905
|
64241
|
64941
|
64942
|
66255
|
70866
|
70867
|
70868
|
70869
|
70870
|
70871
|
76387
|
76388
|
76389
|
76390
|
76391
|
76392
|
78232
|
78233
|
78234
|
78235
|
78236
|
78237
|
78238
|
78240
|
79269
|
83318
|
83319
|
83320
|
83321
|
83322
|
83323
|
83324
|
83325
|
83326
|
83404
|
83405
|
83406
|
83407
|
83408
|
83409
|
83410
|
83411
|
83412
|
84682
|
84683
|
84684
|
84685
|
84686
|
84687
|
84688
|
84689
|
84690
|
84691
|
87494
|
87495
|
87496
|
87497
|
87498
|
87499
|
87500
|
87501
|
87502
|
87503
|
87608
|
87609
|
87610
|
87617
|
96084
|
96085
|
96086
|
96087
|
96088
|
96089
|
96090
|
96091
|
96092
|
96093
|
96094
|
96095
|
96096
|
96097
|
96098
|
97237
|
101565
|
101566
|
101567
|
101568
|
101569
|
101570
|
101571
|
101572
|
101573
|
101574
|
101575
|
101576
|
101577
|
101578
|
101579
|
101580
|
128341
|
128342
|
128343
|
128344
|
128345
|
128346
|
128347
|
128348
|
128349
|
128350
|
128351
|
128352
|
128353
|
128354
|
128355
|
128356
|
128357
|
128585
|
128642
|
136432
|
136757
|
136768
|
138489
|
138493
|
139028
|
139029
|
139030
|
139031
|
139111
|
139123
|
139124
|
139125
|
139172
|
139173
|
139174