Attachment 87535 Details for Bug 22642 – Bug 22642: Corrections to updatedatebase for bug 12395

[patch] Bug 22642: Corrections to updatedatebase for bug 12395

Bug-22642-Corrections-to-updatedatebase-for-bug-12.patch (text/plain), 1.60 KB, created by Martin Renvoize (ashimema) on 2019-04-08 17:05:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-04-08 17:05:32 UTC

Size: 1.60 KB

patch

obsolete

>From 863d0e70eaf6907d88031d72e0c182f00f3495d8 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 8 Apr 2019 18:04:14 +0100
>Subject: [PATCH] Bug 22642: Corrections to updatedatebase for bug 12395
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> installer/data/mysql/updatedatabase.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 8dc7e04671..7df9ca9138 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -16128,7 +16128,8 @@ if( CheckVersion( $DBversion ) ) {
>         unless ( foreign_key_exists('aqorders', 'aqorders_created_by') ) {
>             $dbh->do( "ALTER TABLE aqorders ADD CONSTRAINT aqorders_created_by FOREIGN KEY (created_by) REFERENCES borrowers (borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE;" );
>         }
>-        $dbh->do( "UPDATE aqorders, aqbasket SET aqorders.created_by = aqbasket.authorisedby  WHERE aqorders.basketno = aqbasket.basketno AND aqorders.created_by IS NULL;" );
>+        $dbh->do( "UPDATE aqbasket LEFT JOIN borrowers ON ( aqbasket.authorisedby = borrowers.borrowernumber ) SET aqbasket.authorisedby = NULL WHERE borrowers.borrowernumber IS NULL;" );
>+        $dbh->do( "UPDATE aqorders LEFT JOIN aqbasket ON ( aqorders.basketno = aqbasket.basketno ) SET aqorders.created_by = aqbasket.authorisedby WHERE aqorders.created_by IS NULL;" );
>     }
>     SetVersion( $DBversion );
>     print "Upgrade to $DBversion done (Bug 12395 - Save order line's creator)\n";
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22642: 87535 | 87552 | 87774