Bugzilla – Attachment 87554 Details for
Bug 21943
Clean up holds template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21943: Clean up holds template
Bug-21943-Clean-up-holds-template.patch (text/plain), 3.97 KB, created by
Katrin Fischer
on 2019-04-08 21:21:08 UTC
(
hide
)
Description:
Bug 21943: Clean up holds template
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-04-08 21:21:08 UTC
Size:
3.97 KB
patch
obsolete
>From 5fd14aac4d2869dc6f64066cd4e9330ebdc326ea Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 4 Dec 2018 16:27:00 +0000 >Subject: [PATCH] Bug 21943: Clean up holds template > >This patch makes a few markup corrections to the holds template in the >staff client: Replace some YUI markup with Bootstrap; Replace invalid >"alt" attributes with "title." > >To test, apply the patch and test the process of placing a hold, both >single and multiple holds. At each step of the process the page should >look correct and adjust well at various browser widths. > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/reserve/request.tt | 39 +++++++++++++--------- > 1 file changed, 24 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 36d6a30c7f..c33f33f9b0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -27,11 +27,15 @@ > <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/catalogue/search.pl">Catalog</a> › Confirm holds</div> > [% END %] > >- <div id="doc3" class="yui-t2"> >+<div class="main container-fluid"> >+ <div class="row"> >+ [% IF ( multi_hold ) # No sidebar menu when placing multiple holds %] >+ <div class="col-md-10 col-md-offset-1"> >+ [% ELSE %] >+ <div class="col-sm-10 col-sm-push-2"> >+ [% END %] >+ <main> > >- <div id="bd"> >- <div id="yui-main"> >- <div class="yui-b"> > [% IF ( noitems ) %] > <div class="dialog alert"> > [%IF (multi_hold) %] >@@ -312,17 +316,17 @@ > <td> > [% IF itemloo.force_hold_level == 'record' # Patron has placed a record level hold previously for this record %] > <span class="error"> >- <i class="fa fa-times fa-lg" alt="Cannot be put on hold"></i> >+ <i class="fa fa-times fa-lg" title="Cannot be put on hold"></i> > Hold must be record level > </span> > [% ELSIF ( itemloo.available ) %] > <input type="radio" name="checkitem" value="[% itemloo.itemnumber | html %]" /> > [% ELSIF ( itemloo.override ) %] > <input type="radio" name="checkitem" class="needsoverride" value="[% itemloo.itemnumber | html %]" /> >- <i class="fa fa-exclamation-triangle fa-lg" style="color:gold" alt="Requires override of hold policy"/></i> >+ <i class="fa fa-exclamation-triangle fa-lg" style="color:gold" title="Requires override of hold policy"/></i> > [% ELSE %] > <span class="error"> >- <i class="fa fa-times fa-lg" alt="Cannot be put on hold"></i> >+ <i class="fa fa-times fa-lg" title="Cannot be put on hold"></i> > [% IF itemloo.not_holdable %] > [% IF itemloo.not_holdable == 'damaged' %] > Item damaged >@@ -646,16 +650,21 @@ > </form> > [% END %] > [% END %] >-</div> >-</div> > >-<div class="yui-b"> >-[% UNLESS ( multi_hold ) %] >- [% INCLUDE 'biblio-view-menu.inc' %] >-[% END %] >+ </main> >+ >+ [% IF ( multi_hold ) # No sidebar menu when placing multiple holds %] >+ </div> <!-- /.col-md-10.col-md-offset-1 --> >+ [% ELSE %] >+ </div> <!-- /.col-sm-10.col-sm-push-2 --> >+ <div class="col-sm-2 col-sm-pull-10"> >+ <aside> >+ [% INCLUDE 'biblio-view-menu.inc' %] >+ </aside> >+ </div> <!-- /.col-sm-2.col-sm-pull-10 --> >+ [% END %] >+ </div> <!-- /.row --> > >-</div> >-</div> > > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21943
:
82847
|
86305
|
86454
|
87533
|
87534
| 87554 |
87555