Bugzilla – Attachment 87579 Details for
Bug 22288
Barcode file does not work in modifying items in batch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22288: Correct item search in batchMod by barcode file
Bug-22288-Correct-item-search-in-batchMod-by-barco.patch (text/plain), 1.39 KB, created by
Martin Renvoize (ashimema)
on 2019-04-09 06:43:08 UTC
(
hide
)
Description:
Bug 22288: Correct item search in batchMod by barcode file
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-04-09 06:43:08 UTC
Size:
1.39 KB
patch
obsolete
>From 5baed3708725d1f9a6015c447366e791d6a73e9d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Sat, 23 Mar 2019 11:44:53 +0000 >Subject: [PATCH] Bug 22288: Correct item search in batchMod by barcode file > >To test: >1 - Have a list of barcodes that exist in your catalog >2 - Go to Tools->Batch item modification >3 - Attempt to modify items using the list >4 - Get an error page >5 - Apply patch >6 - Repeat >7 - Modification should work correctly > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > tools/batchMod.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 85077ab33c..e5b6032900 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -254,9 +254,9 @@ if ($op eq "show"){ > > @contentlist = uniq @contentlist; > if ($filecontent eq 'barcode_file') { >- my $existing_items = Koha::Items->search({ itemnumber => \@contentlist }); >+ my $existing_items = Koha::Items->search({ barcode => \@contentlist }); > @itemnumbers = $existing_items->get_column('itemnumber'); >- my %exists = map {$_=>1} @{$existing_items->get_column('barcode')}; >+ my %exists = map {$_=>1} $existing_items->get_column('barcode'); > @notfoundbarcodes = grep { !$exists{$_} } @contentlist; > } > elsif ( $filecontent eq 'itemid_file') { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22288
:
84847
|
84848
|
87571
| 87579