Attachment 87598 Details for Bug 22357 – Bug 22357: Fix saved reports table when runreport.pl with --store-results is used

[patch] Bug 22357: Fix saved reports table when runreport.pl with --store-results is used

Bug-22357-Fix-saved-reports-table-when-runreportpl.patch (text/plain), 1.71 KB, created by Katrin Fischer on 2019-04-09 11:17:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-04-09 11:17:50 UTC

Size: 1.71 KB

patch

obsolete

>From 3a7cd48b972f9d67aa1226095545c563419513ce Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Tue, 9 Apr 2019 11:13:44 +0000
>Subject: [PATCH] Bug 22357: Fix saved reports table when runreport.pl with
> --store-results is used
>
>At the moment every time you run runreport.pl with the --store-results
>option another line will appear for your report in the saved
>reports table. This is not a data, but a display problem as the
>report is still only stored once.
>
>1) Create a report and note the report number
>2) Run from command line (replace X by report number) :
>    misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results
>3) Go to saved reports table
>4) Look at the table, each run of the cronjob will create a new row
>   in the table instead of just updating the saved results column.
>5) Apply patch
>6) Veriy the table displays correctly again and there are no regressions
>---
> C4/Reports/Guided.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm
>index c4d783f011..e4c24a3043 100644
>--- a/C4/Reports/Guided.pm
>+++ b/C4/Reports/Guided.pm
>@@ -638,7 +638,6 @@ sub get_saved_reports_base_query {
> SELECT s.*, $area_name_sql_snippet, av_g.lib AS groupname, av_sg.lib AS subgroupname,
> b.firstname AS borrowerfirstname, b.surname AS borrowersurname
> FROM saved_sql s
>-LEFT JOIN saved_reports r ON r.report_id = s.id
> LEFT OUTER JOIN authorised_values av_g ON (av_g.category = 'REPORT_GROUP' AND av_g.authorised_value = s.report_group)
> LEFT OUTER JOIN authorised_values av_sg ON (av_sg.category = 'REPORT_SUBGROUP' AND av_sg.lib_opac = s.report_group AND av_sg.authorised_value = s.report_subgroup)
> LEFT OUTER JOIN borrowers b USING (borrowernumber)
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22357: 87598 | 88992 | 89036 | 89055