Attachment 87642 Details for Bug 22563 – Bug 22563: Clean up remaining L cases

[patch] Bug 22563: Clean up remaining L cases

Bug-22563-Clean-up-remaining-L-cases.patch (text/plain), 2.70 KB, created by Martin Renvoize (ashimema) on 2019-04-09 16:30:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-04-09 16:30:50 UTC

Size: 2.70 KB

patch

obsolete

>From 8ee76df136639ab3c446aac8eba022d6182b943b Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 2 Apr 2019 15:36:17 +0100
>Subject: [PATCH] Bug 22563: Clean up remaining L cases
>
>---
> .../data/mysql/atomicupdate/bug_22563.perl    | 44 ++++++++++++++++++-
> 1 file changed, 43 insertions(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_22563.perl b/installer/data/mysql/atomicupdate/bug_22563.perl
>index fd085b56a3..5187cf685a 100644
>--- a/installer/data/mysql/atomicupdate/bug_22563.perl
>+++ b/installer/data/mysql/atomicupdate/bug_22563.perl
>@@ -1,6 +1,7 @@
> $DBversion = 'XXX';    # will be replaced by the RM
> if ( CheckVersion($DBversion) ) {
> 
>+    # Find and correct pathological cases of LR
>     my $sth = $dbh->prepare( "SELECT accountlines_id, issue_id, borrowernumber, itemnumber, amount, manager_id FROM accountlines WHERE accounttype = 'LR' AND amount < 0" );
>     $sth->execute();
>     while ( my $row = $sth->fetchrow_hashref ) {
>@@ -29,6 +30,47 @@ if ( CheckVersion($DBversion) ) {
>           accounttype = 'LR';
>     });
> 
>+    # Find and correct pathalogical cases of L having been converted to W
>+    $sth = $dbh->prepare( "SELECT accountlines_id, issue_id, borrowernumber, itemnumber, amount, manager_id FROM accountlines WHERE accounttype = 'W' AND itemnumber IS NOT NULL" );
>+    $sth->execute();
>+    while ( my $row = $sth->fetchrow_hashref ) {
>+        my $amount = $row->{amount} * -1;
>+        $dbh->do(
>+"INSERT INTO accountlines (accounttype, status, issue_id, borrowernumber, itemnumber, amount, manager_id) VALUES ( ?, ?, ?, ?, ?, ? );",
>+            {},
>+            (
>+                'LOST', 'WAIVERED', $row->{issue_id}, $row->{borrowernumber},
>+                $row->{itemnumber}, $amount, $row->{manager_id}
>+            )
>+        );
>+        my $debit_id = $dbh->last_insert_id();
>+        $dbh->do("INSERT INTO account_offsets (credit_id, debit_id, type, amount) VALUES (?,?,?,?);",{},($row->{accountlines_id}, $debit_id, 'Lost Item Returned', $amount));
>+    }
>+
>+    $dbh->do(qq{
>+        UPDATE
>+          accountlines
>+        SET
>+          accounttype = 'LOST',
>+          status = 'UNRETURNED'
>+        WHERE
>+          accounttype = 'L'
>+        AND
>+          amountoutstanding > 0;
>+    });
>+
>+    $dbh->do(qq{
>+        UPDATE
>+          accountlines
>+        SET
>+          accounttype = 'LOST',
>+          status = 'PAID'
>+        WHERE
>+          accounttype = 'L'
>+        AND
>+          amountoutstanding = 0;
>+    });
>+
>     SetVersion($DBversion);
>-    print "Upgrade to $DBversion done (Bug 22518 - Fix accounttypes for 'L' and 'LR')\n";
>+    print "Upgrade to $DBversion done (Bug 22563 - Fix accounttypes for 'L' and 'LR')\n";
> }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22563: 86913 | 86914 | 87092 | 87093 | 87094 | 87637 | 87638 | 87639 | 87640 | 87641 | 87642 | 87801 | 87802 | 87803 | 87804 | 87805 | 87806 | 88279 | 88280 | 88281 | 88282 | 88283 | 88284 | 88285 | 88323 | 88324 | 88325 | 88326 | 88327 | 88328 | 88720 | 88721 | 88722 | 88723 | 88724 | 88725 | 89462 | 89463 | 89464 | 89465 | 89466 | 89467 | 90221 | 90222 | 90223 | 90224 | 90225 | 90226 | 90227 | 90307 | 90308 | 90309 | 90310 | 90311 | 90312 | 90330 | 90331 | 90332 | 90333 | 90334 | 90335 | 90632 | 90637 | 90667 | 91338 | 91339 | 91340 | 91341 | 91342 | 91343 | 91344 | 91345 | 91346 | 91347 | 91348