Attachment 87723 Details for Bug 22461 – Bug 22461: Clarify and correct the hash reduction

[patch] Bug 22461: Clarify and correct the hash reduction

Bug-22461-Clarify-and-correct-the-hash-reduction.patch (text/plain), 1.28 KB, created by Martin Renvoize (ashimema) on 2019-04-10 13:42:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-04-10 13:42:27 UTC

Size: 1.28 KB

patch

obsolete

>From 6f8499eb5287d3a1b37791b441e061ac1ffdd49b Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 10 Apr 2019 14:39:40 +0100
>Subject: [PATCH] Bug 22461: Clarify and correct the hash reduction
>
>There were a couple of bugs in the previous patch which meant it wasn't
>working as intended. This patch corrects those bugs and simplifies the
>code a little along the way.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Auth_with_ldap.pm | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm
>index 6def54d415..589dbcc68f 100644
>--- a/C4/Auth_with_ldap.pm
>+++ b/C4/Auth_with_ldap.pm
>@@ -223,11 +223,9 @@ sub checkpw_ldap {
>     } elsif ($config{replicate}) { # A2, C2
>         my @columns = Koha::Patrons->columns;
>         my $patron = Koha::Patron->new(
>-            map {
>-                grep join( ' ', @columns ) =~ /$_/
>-                  ? ( $_ => $data{$_} )
>-                  : ()
>-            } keys %borrower
>+            {
>+                map { defined( $borrower{$_} ) ? ( $_ => $borrower{$_} ) : () } @columns
>+            }
>         )->store;
>         die "Insert of new patron failed" unless $patron;
>         $borrowernumber = $patron->borrowernumber;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22461: 86696 | 86697 | 86856 | 87721 | 87722 | 87723 | 88192 | 88193 | 88194 | 88921