Bugzilla – Attachment 87729 Details for
Bug 22680
OPAC language footer not positioned correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22680: OPAC language footer not positioned correctly
Bug-22680-OPAC-language-footer-not-positioned-corr.patch (text/plain), 2.23 KB, created by
Owen Leonard
on 2019-04-10 18:11:51 UTC
(
hide
)
Description:
Bug 22680: OPAC language footer not positioned correctly
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-04-10 18:11:51 UTC
Size:
2.23 KB
patch
obsolete
>From 2438470dfce820f0e4c2ba6bb7099164c5464b37 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 10 Apr 2019 17:55:22 +0000 >Subject: [PATCH] Bug 22680: OPAC language footer not positioned correctly > >This patch modifies the OPAC CSS so that the language-selection footer >is positioned correctly. > >To test, apply the patch and rebuild the OPAC CSS. > >- Enable one or more translations in the OPAC >- View a page in the OPAC which can display in your browser without a > vertical scrollbar (for instance, the OPAC main page with no news > items or OpacMainUserBlock). > - The language-selection footer should appear at the bottom of the > screen. At smaller browser heights the footer should scroll > offscreen. > - Test with content in the opaccredits system preference, and with > OpacKohaUrl enabled. The footer should still be positioned > correctly. >--- > koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >index 20fc1cd..b0f99c9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >@@ -36,6 +36,7 @@ > url('fonts/NotoSans-BoldItalic-webfont.woff') format('woff'); > } > >+$footer-height: 45px; > > body { > background: #FCF9FC none; >@@ -80,10 +81,10 @@ body { > height: auto !important; > height: 100%; > min-height: 100%; >- padding-right: 40px; > padding-left: 40px; >- /* Negative indent footer by it's height */ >- // margin: 0 auto -60px; >+ padding-right: 40px; >+ /* Negative indent footer by its height */ >+ margin: 0 auto -#{$footer-height + 1}; > } > > .fa.fa-icon-black, >@@ -92,8 +93,9 @@ body { > } > > #changelanguage { >+ clear: both; > /* Set the fixed height of the footer here */ >- // height: 60px; >+ min-height: $footer-height; > .nav { > > .active { > > p { >@@ -846,11 +848,11 @@ input[type="text"]:focus { > > .navbar-fixed-bottom { > &.navbar-static-bottom { >- margin-top: .5em; > position: static; > } > .navbar-inner { > box-shadow: none; >+ min-height: $footer-height; > } > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22680
:
87727
|
87729
|
87730
|
87733