Attachment 87827 Details for Bug 22692 – Bug 22692: Check for patron using cardnumber and userid

[patch] Bug 22692: Check for patron using cardnumber and userid

Bug-22692-Check-for-patron-using-cardnumber-and-us.patch (text/plain), 1.12 KB, created by Nick Clemens (kidclamp) on 2019-04-12 01:26:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-04-12 01:26:53 UTC

Size: 1.12 KB

patch

obsolete

>From 18d20f9f82bb150595cded808df33f7131c53195 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 12 Apr 2019 01:23:34 +0000
>Subject: [PATCH] Bug 22692: Check for patron using cardnumber and userid
>
>TO test:
>1 - Set failed login attempts to 1
>2 - Attempt a login with a userid and bad password, no success
>3 - Attempt a login with userid and correct password, prevented because
>locked
>4 - Attempt a login with cardnumber and right password, you are logged
>in
>5 - Log out, try again with userid and correct password, prevented
>because locked?
>6 - Apply patch
>7 - Repeat 1-3 to lock account
>8 - Attempt logging in with cardnumber, you are prevented
>---
> C4/Auth.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index 39c6a6c..18445e8 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -1786,6 +1786,7 @@ sub checkpw {
> 
>     my @return;
>     my $patron = Koha::Patrons->find({ userid => $userid });
>+    $patron = Koha::Patrons->find({ cardnumber => $userid }) unless $patron;
>     my $check_internal_as_fallback = 0;
>     my $passwd_ok = 0;
>     # Note: checkpw_* routines returns:
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 22692: 87826 | 87827 | 87903 | 87904 | 87976 | 87977