Bugzilla – Attachment 87876 Details for
Bug 21975
Unnecessary substitutions in automatic item modification by age
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21975 : (followup) get item datas from previous SQL query
Bug-21975--followup-get-item-datas-from-previous-S.patch (text/plain), 1.40 KB, created by
Fridolin Somers
on 2019-04-12 09:45:54 UTC
(
hide
)
Description:
Bug 21975 : (followup) get item datas from previous SQL query
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2019-04-12 09:45:54 UTC
Size:
1.40 KB
patch
obsolete
>From 8d175561559064ff7d5ecdb10722bf30ba9f1eaf Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 12 Apr 2019 11:42:39 +0200 >Subject: [PATCH] Bug 21975 : (followup) get item datas from previous SQL query > >Forced by removal of C4::Items::GetItem from Bug 21206 >--- > C4/Items.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index dcbf4aef94..f0f70c7307 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -2610,7 +2610,7 @@ sub ToggleNewStatus { > my @params; > > my $query = q| >- SELECT items.biblionumber, items.itemnumber >+ SELECT items.* > FROM items > LEFT JOIN biblioitems ON biblioitems.biblionumber = items.biblionumber > WHERE 1 >@@ -2643,7 +2643,7 @@ sub ToggleNewStatus { > my $itemnumber = $values->{itemnumber}; > for my $substitution ( @$substitutions ) { > next unless $substitution->{field}; >- next if ( $item->{ $substitution->{item_field} } eq $substitution->{value} ); >+ next if ( $values->{ $substitution->{item_field} } eq $substitution->{value} ); > C4::Items::ModItem( { $substitution->{item_field} => $substitution->{value} }, $biblionumber, $itemnumber ) > unless $report_only; > push @{ $report->{$itemnumber} }, $substitution; >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21975
:
82983
|
82984
|
82985
|
87575
|
87576
|
87577
|
87876
|
87877
|
87879
|
87880
|
87881
|
87882
|
87883
|
87889
|
87890
|
87891
|
87892
|
87893