Attachment 87887 Details for Bug 22688 – Bug 22688: TT plugin for pickup locations code wrong

[patch] Bug 22688: TT plugin for pickup locations code wrong

Bug-22688-TT-plugin-for-pickup-locations-code-wron.patch (text/plain), 1.17 KB, created by Kyle M Hall (khall) on 2019-04-12 12:15:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-04-12 12:15:24 UTC

Size: 1.17 KB

patch

obsolete

>From 0a96248541a240c84cb235cdb51ce86edf722b8a Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 11 Apr 2019 09:52:29 -0400
>Subject: [PATCH] Bug 22688: TT plugin for pickup locations code wrong
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Test Plan:
>1) Apply this patch
>2) prove t/db_dependent/Koha/Libraries.t
>
>Signed-off-by: AgustÃn Moyano <agustinmoyano@theke.io>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Template/Plugin/Branches.pm | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/Koha/Template/Plugin/Branches.pm b/Koha/Template/Plugin/Branches.pm
>index 58b13d2fc5..df11ab897d 100644
>--- a/Koha/Template/Plugin/Branches.pm
>+++ b/Koha/Template/Plugin/Branches.pm
>@@ -87,9 +87,6 @@ sub InIndependentBranchesMode {
> 
> sub pickup_locations {
>     my ( $self, $params ) = @_;
>-    $params->{search_params} ||= {};
>-    $params->{search_params}->{pickup_location} = 1;
>-    return $self->all($params);
> 
>     my $selected  = $params->{selected};
>     my $libraries = Koha::Libraries->pickup_locations($params);
>-- 
>2.20.1 (Apple Git-117)

Actions: View | Diff | Splinter Review

Attachments on bug 22688: 87764 | 87765 | 87766 | 87768 | 87772 | 87773 | 87817 | 87818 | 87819 | 87820 | 87884 | 87885 | 87886 | 87887 | 87888