Bugzilla – Attachment 87954 Details for
Bug 21937
Syspref autoBarcode annual doesn't increment properly barcode in some cases
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21937: syspref autoBarcode annual doesn't increment properly barcode
Bug-21937-syspref-autoBarcode-annual-doesnt-increm.patch (text/plain), 2.16 KB, created by
Michal Denar
on 2019-04-14 18:53:22 UTC
(
hide
)
Description:
Bug 21937: syspref autoBarcode annual doesn't increment properly barcode
Filename:
MIME Type:
Creator:
Michal Denar
Created:
2019-04-14 18:53:22 UTC
Size:
2.16 KB
patch
obsolete
>From bda9b9458baeb1cb9c98ace74a5314b14e638056 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Mon, 3 Dec 2018 18:02:03 +0100 >Subject: [PATCH] Bug 21937: syspref autoBarcode annual doesn't increment > properly barcode > >This patch fix the barcode annual builder. The test wil work. > >Signed-off-by: Michal Denar <black23@gmail.com> > >Signed-off-by: Michal Denar <black23@gmail.com> >--- > C4/Barcodes/ValueBuilder.pm | 2 +- > .../intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Barcodes/ValueBuilder.pm b/C4/Barcodes/ValueBuilder.pm >index 81747dee67..ef9f28e057 100644 >--- a/C4/Barcodes/ValueBuilder.pm >+++ b/C4/Barcodes/ValueBuilder.pm >@@ -89,7 +89,7 @@ sub get_barcode { > my $nextnum; > my $query = "select max(cast( substring_index(barcode, '-',-1) as signed)) from items where barcode like ?"; > my $sth=C4::Context->dbh->prepare($query); >- $sth->execute("$args->{year}%"); >+ $sth->execute($args->{year} . '-%'); > while (my ($count)= $sth->fetchrow_array) { > warn "Examining Record: $count" if $DEBUG; > $nextnum = $count if $count; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >index 414ce47ea9..0f547e4df5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >@@ -105,8 +105,8 @@ Cataloging: > - pref: autoBarcode > choices: > incremental: generated in the form 1, 2, 3. >- annual: generated in the form <year>-0001, <year>-0002. >- hbyymmincr: generated in the form <branchcode>yymm0001. >+ annual: generated in the form <year>-0001, <year>-0002. >+ hbyymmincr: generated in the form <branchcode>yymm0001. > EAN13: incremental EAN-13 barcodes > "OFF": not generated automatically. > - >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21937
:
82828
|
82829
|
87953
|
87954
|
88162
|
88163