Attachment 87968 Details for Bug 22652 – Bug 22652 - Editing Course reserves is broken

[patch] Bug 22652 - Editing Course reserves is broken

Bug-22652---Editing-Course-reserves-is-broken.patch (text/plain), 2.35 KB, created by Chris Cormack on 2019-04-14 22:41:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2019-04-14 22:41:08 UTC

Size: 2.35 KB

patch

obsolete

>From bd3ec3e12a6334aae66bf003984d5d582ef1e711 Mon Sep 17 00:00:00 2001
>From: Lyon3 Team <koha@univ-lyon3.fr>
>Date: Thu, 11 Apr 2019 10:48:42 +0200
>Subject: [PATCH] Bug 22652 - Editing Course reserves is broken
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>To test:
>1. Create a course reserve or go on an existing one
>2. Add items and add a change for the holdingbranch
>3. On the list of items in this course reserve
>(course_reserves/course-details.pl?course_id=xx), click on "edit" at the
>end of a row :
>
>Without the patch, you can't see the holdingbranch you have choose for
>this item, but you see "LEAVE UNCHANGED"
>
>With the patch, you can see the holdingbranch you have choose when
>adding this item in the course
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>Signed-off-by: MikaÃ«l Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> .../intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt    | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
>index 6c1c5f852e..919c7d57c6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
>@@ -88,7 +88,7 @@
>                         <select id="holdingbranch" name="holdingbranch">
>                             <option value="">LEAVE UNCHANGED</option>
>                             [% FOREACH b IN Branches.all() %]
>-                                [% IF course_item.holdingbranch.defined && ( ( course.enabled == 'yes' && b.value == item.holdingbranch ) || ( course.enabled == 'no' && b.value == course_item.holdingbranch ) ) %]
>+                                [% IF course_item.holdingbranch.defined && ( ( course.enabled == 'yes' && b.branchcode == item.holdingbranch ) || ( course.enabled == 'no' && b.branchcode == course_item.holdingbranch ) ) %]
>                                     <option value="[% b.branchcode | html %]" selected="selected">[% b.branchname | html %]</option>
>                                 [% ELSE %]
>                                     <option value="[% b.branchcode | html %]">[% b.branchname | html %]</option>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22652: 87752 | 87756 | 87763 | 87936 | 87968