Bugzilla – Attachment 88019 Details for
Bug 15496
Delete bibliographic record after moving last item to another record(s)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15496: Tidy code block (Whitespace changes only)
Bug-15496-Tidy-code-block-Whitespace-changes-only.patch (text/plain), 2.41 KB, created by
Kyle M Hall (khall)
on 2019-04-15 15:08:04 UTC
(
hide
)
Description:
Bug 15496: Tidy code block (Whitespace changes only)
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-04-15 15:08:04 UTC
Size:
2.41 KB
patch
obsolete
>From 019360e502dfb1c8463b09a7eba58f93d01d89b2 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 12 Apr 2019 13:07:18 -0400 >Subject: [PATCH] Bug 15496: Tidy code block (Whitespace changes only) > >--- > cataloguing/moveitem.pl | 50 +++++++++++++++++++++++------------------ > 1 file changed, 28 insertions(+), 22 deletions(-) > >diff --git a/cataloguing/moveitem.pl b/cataloguing/moveitem.pl >index 5ef4ffe259..49641f45e2 100755 >--- a/cataloguing/moveitem.pl >+++ b/cataloguing/moveitem.pl >@@ -65,38 +65,44 @@ $template->param(bibliotitle => $biblio->title); > $template->param(biblionumber => $biblionumber); > > # If we already have the barcode of the item to move and the biblionumber to move the item to >-if ($barcode && $biblionumber) { >+if ( $barcode && $biblionumber ) { > > my $itemnumber; >- my $item = Koha::Items->find({ barcode => $barcode }); >+ my $item = Koha::Items->find( { barcode => $barcode } ); > > if ($item) { > > $itemnumber = $item->itemnumber; > my $frombiblionumber = $item->biblionumber; > >- my $moveresult = MoveItemFromBiblio($itemnumber, $frombiblionumber, $biblionumber); >- if ($moveresult) { >- $template->param(success => 1); >- } else { >- $template->param(error => 1, >- errornonewitem => 1); >- } >+ my $moveresult = MoveItemFromBiblio( $itemnumber, $frombiblionumber, $biblionumber ); >+ if ($moveresult) { >+ $template->param( success => 1 ); >+ } >+ else { >+ $template->param( >+ error => 1, >+ errornonewitem => 1 >+ ); >+ } > >- >- } else { >- $template->param(error => 1, >- errornoitem => 1); >- } >+ } >+ else { >+ $template->param( >+ error => 1, >+ errornoitem => 1 >+ ); >+ } > $template->param( >- barcode => $barcode, >- itemnumber => $itemnumber, >- ); >- >-} else { >- $template->param(missingparameter => 1); >- if (!$barcode) { $template->param(missingbarcode => 1); } >- if (!$biblionumber) { $template->param(missingbiblionumber => 1); } >+ barcode => $barcode, >+ itemnumber => $itemnumber, >+ ); >+ >+} >+else { >+ $template->param( missingparameter => 1 ); >+ if ( !$barcode ) { $template->param( missingbarcode => 1 ); } >+ if ( !$biblionumber ) { $template->param( missingbiblionumber => 1 ); } > } > > >-- >2.20.1 (Apple Git-117)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15496
:
88004
|
88005
|
88006
|
88008
|
88015
|
88016
|
88017
|
88018
|
88019
|
88020
|
88026
|
88027
|
88028
|
88029
|
88030
|
88031
|
88032
|
88165
|
88166
|
88167
|
88168
|
88169
|
88170
|
88171
|
88172
|
88215
|
88225
|
88226
|
88227
|
88228
|
88229
|
88230
|
88892
|
88893
|
88894
|
88895
|
88896
|
88897
|
88903
|
88905
|
88920
|
88938
|
88950