Attachment 88043 Details for Bug 22632 – Bug 22632: Add logging of merged patrons

[patch] Bug 22632: Add logging of merged patrons

Bug-22632-Add-logging-of-merged-patrons.patch (text/plain), 1.22 KB, created by axel on 2019-04-16 08:51:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: axel

Created: 2019-04-16 08:51:21 UTC

Size: 1.22 KB

patch

obsolete

>From 3e068f8890890c733f601c38d4a9c19243f82a91 Mon Sep 17 00:00:00 2001
>From: Axel Amghar <axel.amghar@gmail.com>
>Date: Fri, 12 Apr 2019 11:17:33 +0200
>Subject: [PATCH] Bug 22632: Add logging of merged patrons
>
>without this patch , when patrons are merged , you can't see the merge in the log viewer.
>
>    To test:
>    -Apply the patch
>    -Make sure you have "BorrowersLog" on in you System Preference
>    -Search patrons
>    -Check two ore more patrons
>    -Merge selected patrons
>    -Merge patrons
>    -Go to log viewer
>    - Make sure there is the line with the action : "Merge"
>---
> Koha/Patron.pm | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index cc1892b..289098e 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -493,6 +493,11 @@ sub merge_with {
> 
>             $patron->move_to_deleted();
>             $patron->delete();
>+
>+        if (C4::Context->preference("BorrowersLog")){
>+                my $info = $patron->firstname. " " . $patron->surname . " (".$patron->cardnumber . ")". " has been merged into " . $self->firstname . " " . $self->surname . " (".$self->cardnumber . ")" ;
>+                logaction("Patrons", "Merge", $patron_id, $info );
>+            }
>         }
>     });
> 
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 22632: 87778 | 87920 | 87921 | 87922 | 87923 | 87926 | 87995 | 87996 | 87997 | 87998 | 87999 | 88043 | 88044 | 88045 | 88046 | 89728 | 89729 | 89730 | 89731 | 157260 | 157261 | 157262 | 157263 | 157264 | 157265 | 157266 | 157267 | 157268 | 157269 | 157270 | 157271 | 157278 | 157281 | 157286 | 159553 | 159554 | 159555 | 159556 | 159557 | 159558