Attachment 88074 Details for Bug 22715 – Bug 22715: Searching for patrons with "" in the circulation note hangs patron search

[patch] Bug 22715: Searching for patrons with "" in the circulation note hangs patron search

Bug-22715-Searching-for-patrons-with--in-the-circu.patch (text/plain), 1.98 KB, created by Kyle M Hall (khall) on 2019-04-16 14:36:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-04-16 14:36:24 UTC

Size: 1.98 KB

patch

obsolete

>From ea752abd57e22bca6e1c57c10e07a3a337dde0a6 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 16 Apr 2019 10:34:56 -0400
>Subject: [PATCH] Bug 22715: Searching for patrons with "" in the circulation
> note hangs patron search
>
>To replicate:
>Edit a patron to have a circ note, include quoted text in it, such as "this is quoted string"
>Go to the patron search, search for a set of results that would include the patron with the quotes in the note
>Enjoy looking at "Processing" for forever.
>
>Test Plan:
>1) Apply this patch
>2) Attempt to replicate using the steps above
>---
> .../prog/en/modules/members/tables/members_results.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>index 607146e269..92ba8602e3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>@@ -31,7 +31,7 @@
> "dt_fines":
> "[% IF data.fines < 0 %][% data.fines | $Price %] [% ELSIF data.fines > 0 %] [% data.fines | $Price %] [% ELSE %] [% data.fines | $Price %] [% END %]",
> "dt_borrowernotes":
>- "[% data.borrowernotes.replace('\\\\' , '\\\\') |html_line_break |collapse %]",
>+ "[% data.borrowernotes.replace('\\\\' , '\\\\') | replace( "'", "\\'" ) | replace( '"', '\\"' ) |html_line_break |collapse %]",
> "dt_action":
> "<a href='/cgi-bin/koha/members/memberentry.pl?op=modify&amp;destination=circ&amp;borrowernumber=[% data.borrowernumber | html %]' class='btn btn-default btn-xs'> Edit</a>",
> "borrowernumber":
>-- 
>2.20.1 (Apple Git-117)

Actions: View | Diff | Splinter Review

Attachments on bug 22715: 88074 | 88076 | 88077 | 88116 | 88749 | 88786 | 88804 | 88805 | 88806