Attachment 88240 Details for Bug 13795 – Bug 13795: Remove occurences of unused columns in code

[patch] Bug 13795: Remove occurences of unused columns in code

Bug-13795-Remove-occurences-of-unused-columns-in-c.patch (text/plain), 2.39 KB, created by Katrin Fischer on 2019-04-17 20:08:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-04-17 20:08:32 UTC

Size: 2.39 KB

patch

obsolete

>From 3970c75de5c90ea7ec52ba42013d894978dcbba1 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Wed, 20 Mar 2019 15:29:32 +0000
>Subject: [PATCH] Bug 13795: Remove occurences of unused columns in code
>
>These patch removes these two columns from backfill_statstics script
>and from columns.def - this file is used to create description in guided
>reports
>
>Test plan:
>1. Run installer/data/mysql/backfull_statistics.pl
>--> without this patch, there are associatedborrower and usercode errors
>reported
>--> with patch, these two columns are not reported
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> installer/data/mysql/backfill_statistics.pl | 2 --
> koha-tmpl/intranet-tmpl/prog/en/columns.def | 1 -
> 2 files changed, 3 deletions(-)
>
>diff --git a/installer/data/mysql/backfill_statistics.pl b/installer/data/mysql/backfill_statistics.pl
>index 8308b6bfdd..daa8e831ad 100755
>--- a/installer/data/mysql/backfill_statistics.pl
>+++ b/installer/data/mysql/backfill_statistics.pl
>@@ -24,9 +24,7 @@ sub get_counts() {
> 	(SELECT count(*) FROM statistics WHERE branch="NO_LIBRARY"       ) AS NO_LIBRARY,
> 	(SELECT count(*) FROM statistics WHERE branch             IS NULL) AS NULL_BRANCH,
> 	(SELECT count(*) FROM statistics WHERE itemtype           IS NULL AND itemnumber IS NOT NULL) AS NULL_ITEMTYPE,
>-	(SELECT count(*) FROM statistics WHERE usercode           IS NULL) AS NULL_USERCODE,
> 	(SELECT count(*) FROM statistics WHERE borrowernumber     IS NULL) AS NULL_BORROWERNUMBER,
>-	(SELECT count(*) FROM statistics WHERE associatedborrower IS NULL) AS NULL_ASSOCIATEDBORROWER,
> 	(SELECT count(*) FROM statistics                                 ) AS Total
> 	);
> 	my $sth = $dbh->prepare($query);
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/columns.def b/koha-tmpl/intranet-tmpl/prog/en/columns.def
>index 70733607ed..05112eb704 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/columns.def
>+++ b/koha-tmpl/intranet-tmpl/prog/en/columns.def
>@@ -111,7 +111,6 @@
> <field name="statistics.value">Value</field>
> <field name="statistics.type">Type</field>
> <field name="statistics.other"></field>
>-<field name="statistics.usercode">User code</field>
> <field name="statistics.itemnumber">Item number</field>
> <field name="statistics.itemtype">Itemtype</field>
> <field name="statistics.borrowernumber">Borrower number</field>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 13795: 36578 | 47555 | 86809 | 86810 | 86811 | 88233 | 88234 | 88235 | 88238 | 88239 | 88240