Bugzilla – Attachment 88286 Details for
Bug 22521
Convert fines handling to use 'status' instead of two accounttypes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22521: (RM follow-up) Adjust tests to use new accounttype
Bug-22521-RM-follow-up-Adjust-tests-to-use-new-acc.patch (text/plain), 6.81 KB, created by
Nick Clemens (kidclamp)
on 2019-04-18 10:33:03 UTC
(
hide
)
Description:
Bug 22521: (RM follow-up) Adjust tests to use new accounttype
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-04-18 10:33:03 UTC
Size:
6.81 KB
patch
obsolete
>From 7b95aae1bb44fd0886f97024ad5071da95408623 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 18 Apr 2019 10:32:32 +0000 >Subject: [PATCH] Bug 22521: (RM follow-up) Adjust tests to use new accounttype > >--- > t/db_dependent/Koha/Account.t | 48 +++++++++++++++++++++---------------------- > 1 file changed, 24 insertions(+), 24 deletions(-) > >diff --git a/t/db_dependent/Koha/Account.t b/t/db_dependent/Koha/Account.t >index d2724e1af1..d295b340a2 100755 >--- a/t/db_dependent/Koha/Account.t >+++ b/t/db_dependent/Koha/Account.t >@@ -60,10 +60,10 @@ subtest 'outstanding_debits() tests' => sub { > my $account = $patron->account; > > my @generated_lines; >- push @generated_lines, $account->add_debit({ amount => 1, interface => 'commandline', type => 'fine' }); >- push @generated_lines, $account->add_debit({ amount => 2, interface => 'commandline', type => 'fine' }); >- push @generated_lines, $account->add_debit({ amount => 3, interface => 'commandline', type => 'fine' }); >- push @generated_lines, $account->add_debit({ amount => 4, interface => 'commandline', type => 'fine' }); >+ push @generated_lines, $account->add_debit({ amount => 1, interface => 'commandline', type => 'overdue' }); >+ push @generated_lines, $account->add_debit({ amount => 2, interface => 'commandline', type => 'overdue' }); >+ push @generated_lines, $account->add_debit({ amount => 3, interface => 'commandline', type => 'overdue' }); >+ push @generated_lines, $account->add_debit({ amount => 4, interface => 'commandline', type => 'overdue' }); > > my $lines = $account->outstanding_debits(); > my @lines_arr = $account->outstanding_debits(); >@@ -387,10 +387,10 @@ subtest 'lines() tests' => sub { > $account->add_credit({ amount => 4, interface => 'commandline' }); > > # Add Debits >- $account->add_debit({ amount => 1, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 2, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 3, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 4, interface => 'commandline', type => 'fine' }); >+ $account->add_debit({ amount => 1, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 2, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 3, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 4, interface => 'commandline', type => 'overdue' }); > > # Paid Off > $account->add_credit( { amount => 1, interface => 'commandline' } ) >@@ -423,10 +423,10 @@ subtest 'reconcile_balance' => sub { > $account->add_credit({ amount => 5, interface => 'commandline' }); > > # Add Debits >- $account->add_debit({ amount => 1, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 2, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 3, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 4, interface => 'commandline', type => 'fine' }); >+ $account->add_debit({ amount => 1, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 2, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 3, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 4, interface => 'commandline', type => 'overdue' }); > > # Paid Off > Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 0, interface => 'commandline' })->store; >@@ -461,10 +461,10 @@ subtest 'reconcile_balance' => sub { > $account->add_credit({ amount => 4, interface => 'commandline' }); > > # Add Debits >- $account->add_debit({ amount => 1, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 2, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 3, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 4, interface => 'commandline', type => 'fine' }); >+ $account->add_debit({ amount => 1, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 2, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 3, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 4, interface => 'commandline', type => 'overdue' }); > > # Paid Off > Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 0, interface => 'commandline' })->store; >@@ -499,11 +499,11 @@ subtest 'reconcile_balance' => sub { > $account->add_credit({ amount => 4, interface => 'commandline' }); > > # Add Debits >- $account->add_debit({ amount => 1, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 2, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 3, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 4, interface => 'commandline', type => 'fine' }); >- $account->add_debit({ amount => 5, interface => 'commandline', type => 'fine' }); >+ $account->add_debit({ amount => 1, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 2, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 3, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 4, interface => 'commandline', type => 'overdue' }); >+ $account->add_debit({ amount => 5, interface => 'commandline', type => 'overdue' }); > > # Paid Off > Koha::Account::Line->new({ borrowernumber => $patron->id, amount => 1, amountoutstanding => 0, interface => 'commandline' })->store; >@@ -536,9 +536,9 @@ subtest 'reconcile_balance' => sub { > $account->add_credit({ amount => 3, interface => 'commandline' }); > > # Add Debits >- my $debit_1 = $account->add_debit({ amount => 1, interface => 'commandline', type => 'fine' }); >- my $debit_2 = $account->add_debit({ amount => 2, interface => 'commandline', type => 'fine' }); >- my $debit_3 = $account->add_debit({ amount => 3, interface => 'commandline', type => 'fine' }); >+ my $debit_1 = $account->add_debit({ amount => 1, interface => 'commandline', type => 'overdue' }); >+ my $debit_2 = $account->add_debit({ amount => 2, interface => 'commandline', type => 'overdue' }); >+ my $debit_3 = $account->add_debit({ amount => 3, interface => 'commandline', type => 'overdue' }); > > is( $account->balance(), 2, "Account balance is 2" ); > is( $account->outstanding_debits->total_outstanding, 6, 'Outstanding debits sum 6' ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22521
:
86808
|
86890
|
86891
|
86892
|
86893
|
86894
|
86895
|
86896
|
86897
|
86898
|
86899
|
86900
|
86901
|
86902
|
86918
|
86919
|
86920
|
86921
|
87063
|
87083
|
87084
|
87085
|
87086
|
87087
|
87097
|
87098
|
87099
|
87100
|
87101
|
87209
|
87210
|
87211
|
87212
|
87213
|
87214
|
87215
|
87216
|
87217
|
87218
|
87219
|
87220
|
87619
|
87620
|
87621
|
87622
|
87623
|
87624
|
87678
|
87679
|
87680
|
87681
|
87682
|
87683
|
87787
|
87788
|
87789
|
87790
|
87791
|
87792
|
87808
|
87809
|
87810
|
87811
|
87812
|
87813
|
87814
|
87850
|
87851
|
87852
|
87853
|
87854
|
87855
|
87856
|
87857
|
87858
|
87859
|
87860
|
87861
|
87862
|
87863
|
87864
|
87865
|
88064
|
88065
|
88066
|
88067
|
88068
|
88069
|
88070
|
88071
|
88149
|
88150
|
88151
|
88152
|
88153
|
88154
|
88155
|
88156
| 88286