Bugzilla – Attachment 88294 Details for
Bug 20689
Improve usability of Item search fields administration page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20689: (follow-up) Correct scope of template variables
Bug-20689-follow-up-Correct-scope-of-template-vari.patch (text/plain), 2.86 KB, created by
Owen Leonard
on 2019-04-18 12:21:49 UTC
(
hide
)
Description:
Bug 20689: (follow-up) Correct scope of template variables
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-04-18 12:21:49 UTC
Size:
2.86 KB
patch
obsolete
>From 5dc31c137ebbc0d5d811b49402f19d7074120ad8 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 18 Apr 2019 12:17:13 +0000 >Subject: [PATCH] Bug 20689: (follow-up) Correct scope of template variables > >The removal of the <select>s should have been accompanied by a >correction to the scope of tagfield and tagsubfield. It is also >unnecessary to conditionally include the "value" attribute. > >To test, apply the patch and test the process for editing an item search >field. All the correct values should appear in form fields during edit, >and all values should save correctly. >--- > .../prog/en/includes/admin-items-search-field-form.inc | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc >index 302a9b6..e7286bf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc >@@ -13,29 +13,17 @@ > </li> > <li> > <label class="required" for="label">Label: </label> >- [% IF field %] > <input type="text" name="label" id="label" value="[% field.label | html %]" class="required" required="required" /> >- [% ELSE %] >- <input type="text" name="label" id="label" class="required" required="required" /> >- [% END %] > <span class="required">Required</span> > </li> > <li> > <label class="required" for="tagfield">MARC field: </label> >- [% IF field && field.tagfield == tagfield %] >- <input type="text" id="tagfield" name="tagfield" maxlength="3" size="3" class="required" pattern="[a-zA-Z0-9]+" required="required" value="[% tagfield | html %]" /> >- [% ELSE %] >- <input type="text" id="tagfield" name="tagfield" maxlength="3" size="3" class="required" pattern="[a-zA-Z0-9]+" required="required" /> >- [% END %] >- <span class="required">Required</span> >+ <input type="text" id="tagfield" name="tagfield" maxlength="3" size="3" class="required" pattern="[a-zA-Z0-9]+" required="required" value="[% field.tagfield | html %]" /> >+ <span class="required">Required</span> > </li> > <li> > <label for="tagsubfield">MARC subfield: </label> >- [% IF field && field.tagsubfield == tagsubfield %] >- <input type="text" id="tagsubfield" name="tagsubfield" pattern="[a-zA-Z0-9]+" maxlength="1" size="1" value="[% tagsubfield | html %]" /> >- [% ELSE %] >- <input type="text" id="tagsubfield" name="tagsubfield" pattern="[a-zA-Z0-9]+" maxlength="1" size="1" /> >- [% END %] >+ <input type="text" id="tagsubfield" name="tagsubfield" pattern="[a-zA-Z0-9]+" maxlength="1" size="1" value="[% field.tagsubfield | html %]" /> > </li> > <li> > <label for="authorised_values_category">Authorised values category: </label> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20689
:
77640
|
79554
|
79779
|
80538
|
80539
|
80712
|
80713
|
81137
|
81150
|
81151
|
83795
|
83796
|
83827
|
87955
|
87956
|
87957
|
88294
|
124056
|
124057
|
124058
|
124059
|
131038
|
131039
|
131040
|
131041