Attachment 88323 Details for Bug 22563 – Bug 22563: Be more descriptive with accountypes

[patch] Bug 22563: Be more descriptive with accountypes

Bug-22563-Be-more-descriptive-with-accountypes.patch (text/plain), 23.79 KB, created by Martin Renvoize (ashimema) on 2019-04-18 15:57:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-04-18 15:57:59 UTC

Size: 23.79 KB

patch

obsolete

>From b3ea8f2123e11ac8a536bc6e5cee18cb2d9029e0 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 22 Mar 2019 15:25:16 +0000
>Subject: [PATCH] Bug 22563: Be more descriptive with accountypes
>
>Convert 'L' to 'LOST' to become more descriptive in it's use.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Accounts.pm | 2 +-
> C4/Circulation.pm | 2 +-
> Koha/Account.pm | 4 +-
> .../prog/en/includes/accounts.inc | 2 +-
> .../prog/en/modules/members/maninvoice.tt | 2 +-
> .../bootstrap/en/includes/account-table.inc | 2 +-
> opac/opac-user.pl | 2 +-
> t/db_dependent/Accounts.t | 40 +++++++++----------
> t/db_dependent/Circulation.t | 10 ++---
> 9 files changed, 33 insertions(+), 33 deletions(-)
>
>diff --git a/C4/Accounts.pm b/C4/Accounts.pm
>index f7950e102a..4c01194c97 100644
>--- a/C4/Accounts.pm
>+++ b/C4/Accounts.pm
>@@ -91,7 +91,7 @@ sub chargelostitem{
> my $existing_charges = $account->lines->search(
> {
> itemnumber => $itemnumber,
>- accounttype => 'L',
>+ accounttype => 'LOST',
> }
> )->count();
> 
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index b8a774af46..d6bf5bccdc 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2390,7 +2390,7 @@ sub _FixAccountForLostAndReturned {
> my $accountlines = Koha::Account::Lines->search(
> {
> itemnumber => $itemnumber,
>- accounttype => { -in => [ 'L', 'W' ] },
>+ accounttype => { -in => [ 'LOST', 'W' ] },
> },
> {
> order_by => { -desc => [ 'date', 'accountlines_id' ] }
>diff --git a/Koha/Account.pm b/Koha/Account.pm
>index 9d66e70f7c..8a5d4362d9 100644
>--- a/Koha/Account.pm
>+++ b/Koha/Account.pm
>@@ -108,7 +108,7 @@ sub pay {
> $fine->amountoutstanding($new_amountoutstanding)->store();
> $balance_remaining = $balance_remaining - $amount_to_pay;
> 
>- if ( $fine->itemnumber && $fine->accounttype && ( $fine->accounttype eq 'L' ) )
>+ if ( $fine->itemnumber && $fine->accounttype && ( $fine->accounttype eq 'LOST' ) )
> {
> C4::Circulation::ReturnLostItem( $self->{patron_id}, $fine->itemnumber );
> }
>@@ -721,7 +721,7 @@ our $account_type_credit = {
> our $account_type_debit = {
> 'account' => 'A',
> 'overdue' => 'OVERDUE',
>- 'lost_item' => 'L',
>+ 'lost_item' => 'LOST',
> 'new_card' => 'N',
> 'sundry' => 'M',
> 'processing' => 'PF',
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc
>index 010a754d6f..05ed8d1491 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc
>@@ -8,7 +8,7 @@
> [%- CASE 'OVERDUE' -%]Fine[%- PROCESS account_status_description account=account -%]
> [%- CASE 'A' -%]Account management fee
> [%- CASE 'M' -%]Sundry
>- [%- CASE 'L' -%]Lost item
>+ [%- CASE 'LOST' -%]Lost item
> [%- CASE 'W' -%]Writeoff[%- PROCESS account_status_description account=account -%]
> [%- CASE 'HE' -%]Hold waiting too long
> [%- CASE 'Rent' -%]Rental fee
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>index 213641047a..7ce2a42997 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>@@ -79,7 +79,7 @@
> [% INCLUDE 'str/members-menu.inc' %]
> [% Asset.js("js/members-menu.js") | $raw %]
> <script>
>- var type_fees = {'L':'','OVERDUE':'','A':'','N':'','M':''};
>+ var type_fees = {'LOST':'','OVERDUE':'','A':'','N':'','M':''};
> [% FOREACH invoice_types_loo IN invoice_types_loop %]
> type_fees['[% invoice_types_loo.authorised_value | html %]'] = "[% invoice_types_loo.lib | html %]";
> [% END %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc
>index 2e29d8ec66..bc4c0313b0 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc
>@@ -38,7 +38,7 @@
> [% CASE 'OVERDUE' %]Fine[%- PROCESS account_status_description account=account -%]
> [% CASE 'A' %]Account management fee
> [% CASE 'M' %]Sundry
>- [% CASE 'L' %]Lost item
>+ [% CASE 'LOST' %]Lost item
> [% CASE 'W' %]Writeoff[%- PROCESS account_status_description account=account -%]
> [% CASE 'HE' %]Hold waiting too long
> [% CASE 'Rent' %]Rental fee
>diff --git a/opac/opac-user.pl b/opac/opac-user.pl
>index 4ef0fb3c0b..49a8800e11 100755
>--- a/opac/opac-user.pl
>+++ b/opac/opac-user.pl
>@@ -185,7 +185,7 @@ if ( $pending_checkouts->count ) { # Useless test
> {
> borrowernumber => $patron->borrowernumber,
> amountoutstanding => { '>' => 0 },
>- accounttype => [ 'OVERDUE', 'L' ],
>+ accounttype => [ 'OVERDUE', 'LOST' ],
> itemnumber => $issue->{itemnumber}
> },
> );
>diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t
>index 17b91cca9e..1e214fa7fc 100644
>--- a/t/db_dependent/Accounts.t
>+++ b/t/db_dependent/Accounts.t
>@@ -77,7 +77,7 @@ my $item = $builder->build( { source => 'Item', value => { itype => $itemtype-
> my $patron = $builder->build( { source => 'Borrower' } );
> my $amount = '5.000000';
> my $description = "Test fee!";
>-my $type = 'L';
>+my $type = 'LOST';
> my $note = 'Test note!';
> warning_like {
> C4::Accounts::manualinvoice( $patron->{borrowernumber},
>@@ -580,38 +580,38 @@ subtest "C4::Accounts::chargelostitem tests" => sub {
> t::lib::Mocks::mock_preference('useDefaultReplacementCost', '0');
> 
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
> ok( !$lostfine, "No lost fine if no replacementcost or default when pref off");
> ok( !$procfee, "No processing fee if no processing fee");
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 6.12, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
> ok( $lostfine->amount == 6.12, "Lost fine equals replacementcost when pref off and no default set");
> ok( !$procfee, "No processing fee if no processing fee");
> $lostfine->delete();
> 
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
> ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
> ok( !$procfee, "No processing fee if no processing fee");
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 6.12, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
> ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
> ok( !$procfee, "No processing fee if no processing fee");
> $lostfine->delete();
> 
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
> ok( !$lostfine, "No lost fine if no replacementcost and no default set when pref off");
> ok( $procfee->amount == 8.16, "Processing fee if processing fee");
> is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
> $procfee->delete();
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 6.12, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
> ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and no default set");
> ok( $procfee->amount == 8.16, "Processing fee if processing fee");
>@@ -620,14 +620,14 @@ subtest "C4::Accounts::chargelostitem tests" => sub {
> $procfee->delete();
> 
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
> ok( !$lostfine, "No lost fine if no replacementcost but default set when pref off");
> ok( $procfee->amount == 2.04, "Processing fee if processing fee");
> is( $procfee->issue_id, $cli_issue_id_4, "Processing fee issue id is correct" );
> $procfee->delete();
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 6.12, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
> ok( $lostfine->amount == 6.12 , "Lost fine equals replacementcost when pref off and default set");
> ok( $procfee->amount == 2.04, "Processing fee if processing fee");
>@@ -638,44 +638,44 @@ subtest "C4::Accounts::chargelostitem tests" => sub {
> t::lib::Mocks::mock_preference('useDefaultReplacementCost', '1');
> 
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
> ok( !$lostfine, "No lost fine if no replacementcost or default when pref on");
> ok( !$procfee, "No processing fee if no processing fee");
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber1, 6.12, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });
> is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
> ok( !$procfee, "No processing fee if no processing fee");
> 
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
> is( $lostfine->amount(), "16.320000", "Lost fine is default if no replacementcost but default set when pref on");
> ok( !$procfee, "No processing fee if no processing fee");
> $lostfine->delete();
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber2, 6.12, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
> is( $lostfine->amount, "6.120000" , "Lost fine equals replacementcost when pref on and default set");
> ok( !$procfee, "No processing fee if no processing fee");
> 
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
> ok( !$lostfine, "No lost fine if no replacementcost and default not set when pref on");
> is( $procfee->amount, "8.160000", "Processing fee if processing fee");
> is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
> $procfee->delete();
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber3, 6.12, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber3, accounttype => 'PF' });
> is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and no default set");
> is( $procfee->amount, "8.160000", "Processing fee if processing fee");
> is( $procfee->issue_id, $cli_issue_id_3, "Processing fee issue id is correct" );
> 
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
> is( $lostfine->amount, "4.080000", "Lost fine is default if no replacementcost but default set when pref on");
> is( $procfee->amount, "2.040000", "Processing fee if processing fee");
>@@ -683,7 +683,7 @@ subtest "C4::Accounts::chargelostitem tests" => sub {
> $lostfine->delete();
> $procfee->delete();
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 6.12, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
> is( $lostfine->amount, "6.120000", "Lost fine equals replacementcost when pref on and default set");
> is( $procfee->amount, "2.040000", "Processing fee if processing fee");
>@@ -699,7 +699,7 @@ subtest "C4::Accounts::chargelostitem tests" => sub {
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, '1.99', "Perdedor");
> 
> # Lost Item Fee
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'LOST' });
> ok($lostfine, "Lost fine created");
> is($lostfine->manager_id, $staff_id, "Lost fine manager_id set correctly");
> is($lostfine->issue_id, $cli_issue_id_4, "Lost fine issue_id set correctly");
>@@ -726,7 +726,7 @@ subtest "C4::Accounts::chargelostitem tests" => sub {
> 
> t::lib::Mocks::mock_preference( 'FinesLog', 0 );
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
> is( $schema->resultset('ActionLog')->count(), $action_logs + 0, 'No logs were added' );
> $lostfine->delete();
>@@ -734,7 +734,7 @@ subtest "C4::Accounts::chargelostitem tests" => sub {
> 
> t::lib::Mocks::mock_preference( 'FinesLog', 1 );
> C4::Accounts::chargelostitem( $cli_borrowernumber, $cli_itemnumber4, 0, "Perdedor");
>- $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'L' });
>+ $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'LOST' });
> $procfee = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber4, accounttype => 'PF' });
> is( $schema->resultset('ActionLog')->count(), $action_logs + 2, 'Logs were added' );
> $lostfine->delete();
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 0c12efb34e..79e3b7284e 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -2113,7 +2113,7 @@ subtest '_FixAccountForLostAndReturned' => sub {
> $processfee_amount, 'The right PF amountoutstanding is generated' );
> 
> my $lost_fee_lines = Koha::Account::Lines->search(
>- { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'L' } );
>+ { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'LOST' } );
> is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
> my $lost_fee_line = $lost_fee_lines->next;
> is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
>@@ -2174,7 +2174,7 @@ subtest '_FixAccountForLostAndReturned' => sub {
> $processfee_amount, 'The right PF amountoutstanding is generated' );
> 
> my $lost_fee_lines = Koha::Account::Lines->search(
>- { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'L' } );
>+ { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'LOST' } );
> is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
> my $lost_fee_line = $lost_fee_lines->next;
> is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
>@@ -2243,7 +2243,7 @@ subtest '_FixAccountForLostAndReturned' => sub {
> $processfee_amount, 'The right PF amountoutstanding is generated' );
> 
> my $lost_fee_lines = Koha::Account::Lines->search(
>- { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'L' } );
>+ { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'LOST' } );
> is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
> my $lost_fee_line = $lost_fee_lines->next;
> is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
>@@ -2294,7 +2294,7 @@ subtest '_FixAccountForLostAndReturned' => sub {
> $processfee_amount, 'The right PF amountoutstanding is generated' );
> 
> my $lost_fee_lines = Koha::Account::Lines->search(
>- { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'L' } );
>+ { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'LOST' } );
> is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
> my $lost_fee_line = $lost_fee_lines->next;
> is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
>@@ -2397,7 +2397,7 @@ subtest '_FixAccountForLostAndReturned' => sub {
> LostItem( $item_id, 1 );
> 
> my $lost_fee_lines = Koha::Account::Lines->search(
>- { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'L' } );
>+ { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'LOST' } );
> is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
> my $lost_fee_line = $lost_fee_lines->next;
> is( $lost_fee_line->amount + 0, $replacement_amount, 'The right L amount is generated' );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22563: 86913 | 86914 | 87092 | 87093 | 87094 | 87637 | 87638 | 87639 | 87640 | 87641 | 87642 | 87801 | 87802 | 87803 | 87804 | 87805 | 87806 | 88279 | 88280 | 88281 | 88282 | 88283 | 88284 | 88285 | 88323 | 88324 | 88325 | 88326 | 88327 | 88328 | 88720 | 88721 | 88722 | 88723 | 88724 | 88725 | 89462 | 89463 | 89464 | 89465 | 89466 | 89467 | 90221 | 90222 | 90223 | 90224 | 90225 | 90226 | 90227 | 90307 | 90308 | 90309 | 90310 | 90311 | 90312 | 90330 | 90331 | 90332 | 90333 | 90334 | 90335 | 90632 | 90637 | 90667 | 91338 | 91339 | 91340 | 91341 | 91342 | 91343 | 91344 | 91345 | 91346 | 91347 | 91348