Attachment 88348 Details for Bug 22743 – Bug 22743: Add password modal to overdrive results page

[patch] Bug 22743: Add password modal to overdrive results page

Bug-22743-Add-password-modal-to-overdrive-results-.patch (text/plain), 1.86 KB, created by Nick Clemens (kidclamp) on 2019-04-19 11:30:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-04-19 11:30:14 UTC

Size: 1.86 KB

patch

obsolete

>From 93202967375a36e18d4c68ea3f1e877e542a8f44 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 19 Apr 2019 11:25:43 +0000
>Subject: [PATCH] Bug 22743: Add password modal to overdrive results page
>
>This patch also removes a line abotu ratings which was throwing an error.
>Confirm stars rating for OD results are still shown as expected
>
>To test:
> 1 - Enable overdrive circulation with password required
> 2 - Sign in to OPAC but not overdrive
> 3 - Perform a search that returns overdrive results
> 4 - Click in to results page
>     http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats
> 5 - Note 'Login to OverDrive account' link
> 6 - Click it
> 7 - Nothing happens!
> 8 - Apply patch
> 9 - Repeat
>10 - Success!
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt
>index 62101ac5c6..83884778e3 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt
>@@ -51,7 +51,12 @@
>         </div> 
>     </div> 
> 
>-[% INCLUDE 'overdrive-checkout.inc' %]
>+[% IF ( Koha.Preference('OverDriveCirculation') ) %]
>+    [% INCLUDE 'overdrive-checkout.inc' %]
>+    [% IF ( Koha.Preference('OverDrivePasswordRequired') ) %]
>+        [% INCLUDE 'overdrive-login.inc' %]
>+    [% END %]
>+[% END %]
> 
> [% INCLUDE 'opac-bottom.inc' %]
> [% BLOCK jsinclude %]
>@@ -178,7 +183,6 @@ function search( offset ) {
> 
>         if ( pages.length > 1 ) $( '#top-pages, #bottom-pages' ).find( '.pagination' ).html( '<ul>' + pages.join( '' ) + '</ul>');
> 
>-        $( '#overdrive-results-list input.star' ).rating();
>     } );
> }
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22743: 88348 | 88371 | 88683