Attachment 88354 Details for Bug 22739 – Bug 22739: Test SelfCheckInTimeout <> 0, not just defined

[patch] Bug 22739: Test SelfCheckInTimeout <> 0, not just defined

Bug-22739-Test-SelfCheckInTimeout--0-not-just-defi.patch (text/plain), 1.35 KB, created by Tomás Cohen Arazi (tcohen) on 2019-04-19 12:36:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-04-19 12:36:39 UTC

Size: 1.35 KB

patch

obsolete

>From 23f9ffa519a5f63fb998ed3ad914fd9c49fa74e4 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 19 Apr 2019 09:28:35 -0300
>Subject: [PATCH] Bug 22739: Test SelfCheckInTimeout <> 0, not just defined
>
>On sci-main.pl the preference value is tested for 'defined'. This patch
>tests it is different than empty string too. This was causing a
>JavaScript syntax error, that made it display a wrong message.
>
>To test:
>1 - Blank the syspref SelfCheckInTimeout
>2 - Attempt to checkin something via sci
>=> FAIL: The 'Your request included no check-ins.' message is printed.
>3 - Apply this patch, reload the sci-main.pl page
>4 - Attempt to checkin something via sci
>=> SUCCESS: The UI correctly stacks the scanned barcodes
>5 - Sign off :-D
>---
> opac/sci/sci-main.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/sci/sci-main.pl b/opac/sci/sci-main.pl
>index b76179ecf4..84d2a6cb67 100755
>--- a/opac/sci/sci-main.pl
>+++ b/opac/sci/sci-main.pl
>@@ -94,7 +94,7 @@ if ( $op eq 'check_in' ) {
> }
> 
> # Make sure timeout has a reasonable value
>-my $timeout = C4::Context->preference('SelfCheckInTimeout') // 120;
>+my $timeout = C4::Context->preference('SelfCheckInTimeout') || 120;
> $template->param( refresh_timeout => $timeout );
> 
> output_html_with_http_headers $cgi, $cookie, $template->output, undef, { force_no_caching => 1 };
>-- 
>2.21.0

Actions: View | Diff | Splinter Review

Attachments on bug 22739: 88354 | 88635 | 88636