Attachment 88375 Details for Bug 22701 – Bug 22701: Make items prefetchable from Koha::Biblio

[patch] Bug 22701: Make items prefetchable from Koha::Biblio

Bug-22701-Make-items-prefetchable-from-KohaBiblio.patch (text/plain), 1.31 KB, created by Tomás Cohen Arazi (tcohen) on 2019-04-22 13:12:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-04-22 13:12:55 UTC

Size: 1.31 KB

patch

obsolete

>From d6218709a40118e45d931746dc4e3c477d3c8bc3 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 22 Apr 2019 10:08:41 -0300
>Subject: [PATCH] Bug 22701: Make items prefetchable from Koha::Biblio
>
>This patch makes Koha::Biblio->items use _new_from_dbic instead of
>calling Koha::Items->search. This allows calling it with prefetch
>enabled for the items relationship. No noticeable behaviour change takes
>place besides this.
>
>To test:
>- Run:
>  $ kshell
> k$ prove t/db_dependent/Koha/Biblio.t
>=> SUCCESS: Tests pass!
>- Apply this patch
>- Run:
> k$ prove t/db_dependent/Koha/Biblio.t
>=> SUCCESS: Tests still pass!
>- Sign off :-D
>---
> Koha/Biblio.pm | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index 48a585aea4..b535649b25 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -361,9 +361,12 @@ or list of Koha::Item objects in list context.
> sub items {
>     my ($self) = @_;
> 
>-    $self->{_items} ||= Koha::Items->search( { biblionumber => $self->biblionumber() } );
>+    my $items_rs = $self->_result->items;
> 
>-    return wantarray ? $self->{_items}->as_list : $self->{_items};
>+    return
>+        wantarray
>+        ? Koha::Items->_new_from_dbic($items_rs)->as_list
>+        : Koha::Items->_new_from_dbic($items_rs);
> }
> 
> =head3 itemtype
>-- 
>2.21.0

Actions: View | Diff | Splinter Review

Attachments on bug 22701: 88374 | 88375 | 88490 | 88491