Attachment 88473 Details for Bug 20340 – Bug 20340: Followup to allow OPAC login to complete

[patch] Bug 20340: Followup to allow OPAC login to complete

Bug-20340-Followup-to-allow-OPAC-login-to-complete.patch (text/plain), 1.64 KB, created by axel on 2019-04-23 13:24:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: axel

Created: 2019-04-23 13:24:02 UTC

Size: 1.64 KB

patch

obsolete

>From a6ac54de8aae4fd7e046b38d1cf47059deeb923e Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Tue, 20 Mar 2018 04:03:44 +0000
>Subject: [PATCH] Bug 20340: Followup to allow OPAC login to complete
>
>The Plugin authenticates correctly, the problem is there
>is no patron to match with, and so there is nothing to check
>for authorization and user-details once a login is attempted.
>This will at least let it fail gracefully.
>---
> opac/opac-user.pl | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/opac/opac-user.pl b/opac/opac-user.pl
>index 1fde24b..f6e2586 100755
>--- a/opac/opac-user.pl
>+++ b/opac/opac-user.pl
>@@ -89,14 +89,14 @@ $template->param( shibbolethAuthentication => C4::Context->config('useshibboleth
> 
> # get borrower information ....
> my $patron = Koha::Patrons->find( $borrowernumber );
>-my $borr = $patron->unblessed;
>-# unblessed is a hash vs. object/undef. Hence the use of curly braces here.
>+
>+my $borr = $patron ? $patron->unblessed : {};
> my $borcat = $borr ? $borr->{categorycode} : q{};
> 
> my (  $today_year,   $today_month,   $today_day) = Today();
> my ($warning_year, $warning_month, $warning_day) = split /-/, $borr->{'dateexpiry'};
> 
>-my $debar = Koha::Patrons->find( $borrowernumber )->is_debarred;
>+my $debar = $patron ? $patron->is_debarred : undef;
> my $userdebarred;
> 
> if ($debar) {
>@@ -119,7 +119,7 @@ if ( $userdebarred || $borr->{'gonenoaddress'} || $borr->{'lost'} ) {
>     $canrenew = 0;
> }
> 
>-my $amountoutstanding = $patron->account->balance;
>+my $amountoutstanding = $patron ? $patron->account->balance : 0;
> if ( $amountoutstanding > 5 ) {
>     $borr->{'amountoverfive'} = 1;
> }
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 20340: 72469 | 73089 | 73098 | 73106 | 88470 | 88472 | 88473 | 88474 | 88475 | 88476 | 88477 | 88478 | 88487 | 88488 | 88511 | 88512 | 88518 | 88519 | 88520 | 88521 | 88522 | 88523 | 88526 | 88527 | 91304 | 91305 | 91306 | 91307