Bugzilla – Attachment 88679 Details for
Bug 21460
Filtering ILL requests on borrowernumber does not work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21460: Simplify the code to have only 1 assignment
Bug-21460-Simplify-the-code-to-have-only-1-assignm.patch (text/plain), 1.17 KB, created by
Josef Moravec
on 2019-04-25 05:59:40 UTC
(
hide
)
Description:
Bug 21460: Simplify the code to have only 1 assignment
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-04-25 05:59:40 UTC
Size:
1.17 KB
patch
obsolete
>From 0aa178e5ba30ab72f7cbbd6688e51c4075f1745a Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Tue, 23 Apr 2019 10:09:33 +0100 >Subject: [PATCH] Bug 21460: Simplify the code to have only 1 assignment > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > Koha/REST/V1/Illrequests.pm | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > >diff --git a/Koha/REST/V1/Illrequests.pm b/Koha/REST/V1/Illrequests.pm >index c3c51a592d..f747390792 100644 >--- a/Koha/REST/V1/Illrequests.pm >+++ b/Koha/REST/V1/Illrequests.pm >@@ -56,14 +56,11 @@ sub list { > > # Get all requests > # If necessary, only get those from a specified patron >- my @requests; >- if ($args->{borrowernumber}) { >- @requests = Koha::Illrequests->search( >- { borrowernumber => $args->{borrowernumber} } >- ); >- } else { >- @requests = Koha::Illrequests->as_list; >- } >+ my @requests = Koha::Illrequests->search({ >+ args->{borrowernumber} >+ ? ( borrowernumber => $args->{borrowernumber} ) >+ : () >+ })->as_list; > > # Identify patrons & branches that > # we're going to need and get them >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21460
:
82858
|
83119
|
83184
|
83185
|
83272
|
83305
|
83435
|
83674
|
88444
|
88445
|
88626
| 88679 |
88680
|
88681