Bugzilla – Attachment 88696 Details for
Bug 22729
flgAnonymized shouldn't be NULL and should be renamed anonymized
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22729: (QA follow-up) Ensure no NULL values before setting NOT NULL
Bug-22729-QA-follow-up-Ensure-no-NULL-values-befor.patch (text/plain), 1.48 KB, created by
Martin Renvoize (ashimema)
on 2019-04-25 07:18:16 UTC
(
hide
)
Description:
Bug 22729: (QA follow-up) Ensure no NULL values before setting NOT NULL
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-04-25 07:18:16 UTC
Size:
1.48 KB
patch
obsolete
>From 28d6ac4d917c54e5b7ee776b3a2a74d1299db0a0 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 25 Apr 2019 08:15:58 +0100 >Subject: [PATCH] Bug 22729: (QA follow-up) Ensure no NULL values before > setting NOT NULL > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > installer/data/mysql/atomicupdate/bug_21336_followup.perl | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/installer/data/mysql/atomicupdate/bug_21336_followup.perl b/installer/data/mysql/atomicupdate/bug_21336_followup.perl >index 880d83205e..ff2688900d 100644 >--- a/installer/data/mysql/atomicupdate/bug_21336_followup.perl >+++ b/installer/data/mysql/atomicupdate/bug_21336_followup.perl >@@ -2,6 +2,9 @@ $DBversion = 'XXX'; > if( CheckVersion( $DBversion ) ) { > > if ( column_exists( 'borrowers', 'flgAnonymized' ) ) { >+ $dbh->do(q{ >+ UPDATE borrowers SET flgAnonymized = 0 WHERE flgAnonymized IS NULL >+ }); > $dbh->do(q{ > ALTER TABLE borrowers > CHANGE `flgAnonymized` `anonymized` TINYINT(1) NOT NULL DEFAULT 0 >@@ -9,6 +12,9 @@ if( CheckVersion( $DBversion ) ) { > } > > if ( column_exists( 'deletedborrowers', 'flgAnonymized' ) ) { >+ $dbh->do(q{ >+ UPDATE deletedborrowers SET flgAnonymized = 0 WHERE flgAnonymized IS NULL >+ }); > $dbh->do(q{ > ALTER TABLE deletedborrowers > CHANGE `flgAnonymized` `anonymized` TINYINT(1) NOT NULL DEFAULT 0 >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22729
:
88222
|
88223
|
88224
|
88337
|
88338
|
88339
|
88340
|
88349
|
88350
|
88351
|
88352
|
88353
|
88692
|
88693
|
88694
|
88695
| 88696 |
88745