Attachment 88712 Details for Bug 22511 – Bug 22511: (QA follow-up) Fix update database

[patch] Bug 22511: (QA follow-up) Fix update database

Bug-22511-QA-follow-up-Fix-update-database.patch (text/plain), 1.26 KB, created by Josef Moravec on 2019-04-25 08:37:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-04-25 08:37:37 UTC

Size: 1.26 KB

patch

obsolete

>From 57057bfb6dc4cd268b483c20c0366c0370c568a1 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Thu, 25 Apr 2019 08:25:42 +0000
>Subject: [PATCH] Bug 22511: (QA follow-up) Fix update database
>
>Test plan:
>Run db update (and have some voided accountlines)
>--> without patch it fails with error message similar to:
>    Can't use string ("Payment") as a HASH ref while "strict refs" in use at
>    (eval 1393) line 19.
>--> with patch it runs as expected
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> installer/data/mysql/atomicupdate/bug_22511.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_22511.perl b/installer/data/mysql/atomicupdate/bug_22511.perl
>index 44474285dc..4ec384b072 100644
>--- a/installer/data/mysql/atomicupdate/bug_22511.perl
>+++ b/installer/data/mysql/atomicupdate/bug_22511.perl
>@@ -15,7 +15,7 @@ if ( CheckVersion($DBversion) ) {
>     $sth->execute();
>     while (my $row = $sth->fetchrow_hashref) {
>         $sth2->execute($row->{accountlines_id});
>-        my $result = $sth2->fetchrow;
>+        my $result = $sth2->fetchrow_hashref;
>         my $type = $types_map->{$result->{'type'}} // 'Pay';
>         $sth3->execute($type,$row->{accountlines_id});
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22511: 86674 | 86675 | 86903 | 86904 | 86905 | 86915 | 86916 | 86917 | 87088 | 87089 | 87090 | 87091 | 87221 | 87222 | 87223 | 87224 | 87632 | 87633 | 87634 | 87635 | 87650 | 87651 | 87652 | 87653 | 87654 | 87704 | 87706 | 87796 | 87797 | 87798 | 87799 | 87800 | 87869 | 87870 | 87871 | 87872 | 87873 | 88707 | 88708 | 88709 | 88710 | 88711 | 88712 | 88713 | 88714 | 88715 | 88748