Attachment 88718 Details for Bug 22200 – Bug 22200: Add Tests for change

[patch] Bug 22200: Add Tests for change

Bug-22200-Add-Tests-for-change.patch (text/plain), 2.67 KB, created by Martin Renvoize (ashimema) on 2019-04-25 09:10:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-04-25 09:10:57 UTC

Size: 2.67 KB

patch

obsolete

>From 45b0cddfe1e116e6ae438c9e159ccc70d814ed29 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 18 Apr 2019 09:56:24 +0100
>Subject: [PATCH] Bug 22200: Add Tests for change
>
>Unit tests to check for the addition of a credit of type 'FOR' when
>_FixOverduesOnReturn is called with $exemptfine set to true.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Circulation.t | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 29d13ccd79..0c12efb34e 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -1988,6 +1988,8 @@ subtest 'AddReturn | is_overdue' => sub {
> 
>     my $library = $builder->build( { source => 'Branch' } );
>     my $patron  = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
>+    my $manager = $builder->build_object({ class => "Koha::Patrons" });
>+    t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
> 
>     my $biblioitem = $builder->build( { source => 'Biblioitem' } );
>     my $item = $builder->build(
>@@ -2438,7 +2440,10 @@ subtest '_FixAccountForLostAndReturned' => sub {
> };
> 
> subtest '_FixOverduesOnReturn' => sub {
>-    plan tests => 6;
>+    plan tests => 9;
>+
>+    my $manager = $builder->build_object({ class => "Koha::Patrons" });
>+    t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
> 
>     my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
> 
>@@ -2475,7 +2480,6 @@ subtest '_FixOverduesOnReturn' => sub {
>     is( $accountline->amountoutstanding, '99.000000', 'Fine has the same amount outstanding as previously' );
>     is( $accountline->status, 'RETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status RETURNED )');
> 
>-
>     ## Run again, with exemptfine enabled
>     $accountline->set(
>         {
>@@ -2494,6 +2498,10 @@ subtest '_FixOverduesOnReturn' => sub {
>     is( $accountline->status, 'FORGIVEN', 'Open fine ( account type OVERDUE ) has been set to fine forgiven ( status FORGIVEN )');
>     is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via forgiveness" );
>     is( $offset->amount, '-99.000000', "Amount of offset is correct" );
>+    my $credit = $offset->credit;
>+    is( ref $credit, "Koha::Account::Line", "Found matching credit for fine forgiveness" );
>+    is( $credit->amount, '-99.000000', "Credit amount is set correctly" );
>+    is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" );
> };
> 
> subtest 'Set waiting flag' => sub {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22200: 84339 | 85219 | 88269 | 88270 | 88271 | 88273 | 88304 | 88305 | 88718 | 88719 | 88750 | 88759 | 88760 | 88761 | 88779 | 88780 | 88781