Attachment 88773 Details for Bug 22621 – Bug 22621: Fix filters on subscription search results

[patch] Bug 22621: Fix filters on subscription search results

Bug-22621-Fix-filters-on-subscription-search-resul.patch (text/plain), 3.37 KB, created by Kyle M Hall (khall) on 2019-04-25 12:15:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-04-25 12:15:15 UTC

Size: 3.37 KB

patch

obsolete

>From a757f61c39e71ab4295ee99c3879212162ae63df Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 23 Apr 2019 22:49:46 -0400
>Subject: [PATCH] Bug 22621: Fix filters on subscription search results
>
>Caused by
>  commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b
>  Bug 18426: Allow to edit subscriptions in batch
>
>There is a shift caused by a hidden column, which make the filters
>searching on the previous column.
>
>Test plan:
>- Add 1+ searchable additional field for subscription
>- Create a new subscription
>- Search for subscriptions
>- Use the column filters to filter the results
>=> The results must be filtered accordingly
>
>Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../prog/en/modules/serials/serials-search.tt  | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
>index 6ea103367b..6474c83993 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
>@@ -68,17 +68,19 @@
>       <tfoot>
>         <tr>
>           <td></td>
>-          <td><input type="text" class="dt-filter" data-column_num="0" placeholder="Search ISSN" /></td>
>-          <td><input type="text" class="dt-filter" data-column_num="1" placeholder="Search title" /></td>
>-          <td><input type="text" class="dt-filter" data-column_num="2" placeholder="Search notes" /></td>
>-          <td><input type="text" class="dt-filter" data-column_num="3" placeholder="Search library" /></td>
>-          <td><input type="text" class="dt-filter" data-column_num="4" placeholder="Search location" /></td>
>-          <td><input type="text" class="dt-filter" data-column_num="5" placeholder="Search callnumber" /></td>
>+          <td><input type="text" class="dt-filter" data-column_num="1" placeholder="Search ISSN" /></td>
>+          <td><input type="text" class="dt-filter" data-column_num="2" placeholder="Search title" /></td>
>+          <td><input type="text" class="dt-filter" data-column_num="3" placeholder="Search notes" /></td>
>+          <td><input type="text" class="dt-filter" data-column_num="4" placeholder="Search library" /></td>
>+          <td><input type="text" class="dt-filter" data-column_num="5" placeholder="Search location" /></td>
>+          <td><input type="text" class="dt-filter" data-column_num="6" placeholder="Search callnumber" /></td>
>+          [% SET column_num = 6 %]
>           [% UNLESS closed %]
>-              <td><input type="text" class="dt-filter" data-column_num="6" placeholder="Search expiration date" /></td>
>+              <td><input type="text" class="dt-filter" data-column_num="7" placeholder="Search expiration date" /></td>
>+              [% SET column_num = column_num + 1 %]
>           [% END %]
>           [% FOR field IN additional_fields_for_subscription %]
>-            <td><input type="text" class="dt-filter" data-column_num="[% loop.count + 6 | html %]" placeholder="Search [% field.name | html %]" /></td>
>+            <td><input type="text" class="dt-filter" data-column_num="[% loop.count + column_num | html %]" placeholder="Search [% field.name | html %]" /></td>
>           [% END %]
>           <td></td>
>         </tr>
>-- 
>2.20.1 (Apple Git-117)

Actions: View | Diff | Splinter Review

Attachments on bug 22621: 87315 | 87316 | 88585 | 88730 | 88773