Attachment 88849 Details for Bug 21589 – Bug 21589: Series link formed from 830 field is incorrect

[patch] Bug 21589: Series link formed from 830 field is incorrect

Bug-21589-Series-link-formed-from-830-field-is-inc.patch (text/plain), 7.31 KB, created by Marcel de Rooy on 2019-04-26 06:42:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-04-26 06:42:11 UTC

Size: 7.31 KB

patch

obsolete

>From f087724dc77793ffd1df7016029f8730d16fcd39 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 17 Oct 2018 14:43:11 -0400
>Subject: [PATCH] Bug 21589: Series link formed from 830 field is incorrect
>Content-Type: text/plain; charset=utf-8
>
>Bug 13692 corrected the series link for records using a 490/800 combination
>
>When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)
>
>Test Plan:
>1) Catalog two or more records with 830 fields
>2) Note the series links are broken
>3) Apply this patch
>4) Reload the record details page
>5) The series link should now work
>6) Repeat for the OPAC
>
>Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../prog/en/xslt/MARC21slim2intranetDetail.xsl     | 33 +++++++++++++++++++++-
> .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    | 32 ++++++++++++++++++++-
> 2 files changed, 63 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>index f8f0ba16c9..2f9f8548bb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>@@ -220,7 +220,7 @@
>         </xsl:for-each>
>         
>         <xsl:if test="marc:datafield[@tag=490][@ind1=1]">
>-            <xsl:for-each select="marc:datafield[@tag=800 or @tag=810 or @tag=811 or @tag=830]">
>+            <xsl:for-each select="marc:datafield[@tag=800 or @tag=810 or @tag=811]">
>                 <xsl:choose>
>                     <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>                         <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:subfield[@code='w'], true())"/></xsl:attribute>
>@@ -250,6 +250,37 @@
>                 <xsl:value-of  select="marc:subfield[@code='v']" />
>             <xsl:choose><xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise><xsl:text>; </xsl:text></xsl:otherwise></xsl:choose>
>             </xsl:for-each>
>+
>+            <xsl:for-each select="marc:datafield[@tag=830]">
>+                <xsl:choose>
>+                    <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>+                        <a href="/cgi-bin/koha/catalogue/search.pl?q=rcn:{marc:subfield[@code='w']}">
>+                            <xsl:call-template name="chopPunctuation">
>+                                <xsl:with-param name="chopString">
>+                                    <xsl:call-template name="subfieldSelect">
>+                                        <xsl:with-param name="codes">a_t</xsl:with-param>
>+                                    </xsl:call-template>
>+                                </xsl:with-param>
>+                            </xsl:call-template>
>+                        </a>
>+                    </xsl:when>
>+                    <xsl:otherwise>
>+                        <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=se,phr:"<xsl:value-of select="marc:subfield[@code='a']"/>"</xsl:attribute>
>+                            <xsl:call-template name="chopPunctuation">
>+                                <xsl:with-param name="chopString">
>+                                    <xsl:call-template name="subfieldSelect">
>+                                        <xsl:with-param name="codes">a_t</xsl:with-param>
>+                                    </xsl:call-template>
>+                                </xsl:with-param>
>+                            </xsl:call-template>
>+                        </a>
>+                        <xsl:call-template name="part"/>
>+                    </xsl:otherwise>
>+                </xsl:choose>
>+                <xsl:text>: </xsl:text>
>+                <xsl:value-of  select="marc:subfield[@code='v']" />
>+            <xsl:choose><xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise><xsl:text>; </xsl:text></xsl:otherwise></xsl:choose>
>+            </xsl:for-each>
>         </xsl:if>
> 
>         </span>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index 4f76b762fa..26a307a9dd 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -245,7 +245,7 @@
>         </xsl:for-each>
>         
>         <xsl:if test="marc:datafield[@tag=490][@ind1=1]">
>-            <xsl:for-each select="marc:datafield[@tag=800 or @tag=810 or @tag=811 or @tag=830]">
>+            <xsl:for-each select="marc:datafield[@tag=800 or @tag=810 or @tag=811]">
>                 <xsl:choose>
>                     <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>                         <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:subfield[@code='w'], true())"/></xsl:attribute>
>@@ -275,6 +275,36 @@
>                 <xsl:value-of  select="marc:subfield[@code='v']" />
>             <xsl:choose><xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise><xsl:text>; </xsl:text></xsl:otherwise></xsl:choose>
>             </xsl:for-each>
>+            <xsl:for-each select="marc:datafield[@tag=830]">
>+                <xsl:choose>
>+                    <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>+                        <a href="/cgi-bin/koha/catalogue/search.pl?q=rcn:{marc:subfield[@code='w']}">
>+                            <xsl:call-template name="chopPunctuation">
>+                                <xsl:with-param name="chopString">
>+                                    <xsl:call-template name="subfieldSelect">
>+                                        <xsl:with-param name="codes">a_t</xsl:with-param>
>+                                    </xsl:call-template>
>+                                </xsl:with-param>
>+                            </xsl:call-template>
>+                        </a>
>+                    </xsl:when>
>+                    <xsl:otherwise>
>+                        <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=se,phr:"<xsl:value-of select="marc:subfield[@code='a']"/>"</xsl:attribute>
>+                            <xsl:call-template name="chopPunctuation">
>+                                <xsl:with-param name="chopString">
>+                                    <xsl:call-template name="subfieldSelect">
>+                                        <xsl:with-param name="codes">a_t</xsl:with-param>
>+                                    </xsl:call-template>
>+                                </xsl:with-param>
>+                            </xsl:call-template>
>+                        </a>
>+                        <xsl:call-template name="part"/>
>+                    </xsl:otherwise>
>+                </xsl:choose>
>+                <xsl:text>: </xsl:text>
>+                <xsl:value-of  select="marc:subfield[@code='v']" />
>+            <xsl:choose><xsl:when test="position()=last()"><xsl:text></xsl:text></xsl:when><xsl:otherwise><xsl:text>; </xsl:text></xsl:otherwise></xsl:choose>
>+            </xsl:for-each>
>         </xsl:if>
>         </span>
>         </xsl:if>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21589: 80750 | 82275 | 82654 | 88582 | 88734 | 88849